Skip to content

fix: empty parent pages sidebar issue#32

Merged
minhthanhdang merged 1 commit into
minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-authfrom
minh/empty-parent-pages-sidebar-issue
Jul 17, 2026
Merged

fix: empty parent pages sidebar issue#32
minhthanhdang merged 1 commit into
minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-authfrom
minh/empty-parent-pages-sidebar-issue

Conversation

@minhthanhdang

@minhthanhdang minhthanhdang commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
🚥 Resolves ISSUE_ID

ai-cli-runner PR: https://github.com/readmeio/ai-cli-runner/pull/83

🧰 Changes

  • Pages in second level folders construct slug from top level folder only, so we need to name the md file in the skeleton {second-level-folder}-{page-slug}

🧬 QA & Testing

https://www.loom.com/share/08818eb323c14052a827492f3f5c4310

@minhthanhdang
minhthanhdang changed the base branch from main to minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-auth July 14, 2026 04:11
@jesseyowell

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Organized imports now write parent pages with children to slug directories containing index.md, while leaf pages remain <slug>.md. Nested routed category directories are namespaced using ancestor-based unique names to prevent basename collisions. Pages are staged into these namespaced paths, and each renamed container receives a titled, empty index.md parent page for gitto navigation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/commands/import.js`:
- Around line 4311-4319: Update the content validation logic in
src/validators/content.js to accept generated intermediate container index.md
files when their directory contains descendant Markdown pages, even without a
direct child .md sibling. Preserve the existing validation behavior for
directories with no descendant content, and ensure the generated indexes from
the nestedContainers loop satisfy the validator contract.
- Around line 4287-4293: Update the segRename lookup and assignment in the
nested-container generation logic to key entries by both topDir and origPrefix.
Preserve reuse within the same top-level route while ensuring identical subpaths
under different top-level routes receive independent names and each route is
added to nestedContainers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 885a254e-6061-4e9f-89a8-6ad6a968de80

📥 Commits

Reviewing files that changed from the base of the PR and between f617923 and fdae0cc.

📒 Files selected for processing (1)
  • src/commands/import.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • readmeio/ai (manual)
  • readmeio/gitto (manual)
  • readmeio/markdown (manual)
  • readmeio/readme (manual)

Comment thread src/commands/import.js
Comment thread src/commands/import.js
@minhthanhdang
minhthanhdang merged commit 31a95b9 into minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-auth Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants