fix: ai importer goswift stoplight UI elements footer auth - #36
Conversation
WalkthroughThe import pipeline now requests schema-validated JSON objects from Claude for orphan slotting, icon generation, and organization workflows. Source URLs are resolved through redirects before discovery, redirected llms.txt paths are used for parsing, and crawled navigation removes leaf auth routes while excluding sidebar wrappers. Staged output writes parent pages to folder-backed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/commands/import.test.js (1)
126-128: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the duplicated line.
The
globalThis.fetchoverride assignment on line 127 is identically duplicated.♻️ Proposed fix
test('resolveRedirectedSourceUrl returns null on non-ok responses', async () => { - globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' }) - globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' }) + globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' }) assert.equal(await __test__.resolveRedirectedSourceUrl(new URL('https://example.com/')), null)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/commands/import.test.js` around lines 126 - 128, Remove the duplicated globalThis.fetch override in the resolveRedirectedSourceUrl non-OK response test, leaving a single assignment before the assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/commands/import.test.js`:
- Around line 126-128: Remove the duplicated globalThis.fetch override in the
resolveRedirectedSourceUrl non-OK response test, leaving a single assignment
before the assertion.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 55db4c7f-a819-4258-9336-6d400595d760
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
package.jsonsrc/commands/import.jssrc/commands/import.test.jssrc/prompts/index.js
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
readmeio/ai(manual)readmeio/gitto(manual)readmeio/markdown(manual)readmeio/readme(manual)
🧰 Changes
(#32 was merged into wrong base), this PR merge it to main
🧬 QA & Testing
Provide as much information as you can on how to test what you've done.