Skip to content

fix: ai importer goswift stoplight UI elements footer auth - #36

Merged
minhthanhdang merged 8 commits into
mainfrom
minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-auth
Jul 17, 2026
Merged

fix: ai importer goswift stoplight UI elements footer auth#36
minhthanhdang merged 8 commits into
mainfrom
minh/rm-17411-ai-importer-goswift-stoplight-ui-elements-footer-auth

Conversation

@minhthanhdang

@minhthanhdang minhthanhdang commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
🚥 Resolves ISSUE_ID

🧰 Changes

(#32 was merged into wrong base), this PR merge it to main

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The import pipeline now requests schema-validated JSON objects from Claude for orphan slotting, icon generation, and organization workflows. Source URLs are resolved through redirects before discovery, redirected llms.txt paths are used for parsing, and crawled navigation removes leaf auth routes while excluding sidebar wrappers. Staged output writes parent pages to folder-backed index.md files and namespaces nested category folders. The Claude SDK dependency and default model were updated, with redirect behavior covered by tests.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/commands/import.test.js (1)

126-128: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the duplicated line.

The globalThis.fetch override assignment on line 127 is identically duplicated.

♻️ Proposed fix
 test('resolveRedirectedSourceUrl returns null on non-ok responses', async () => {
-  globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' })
-  globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' })
+  globalThis.fetch = async (url) => ({ ok: false, status: 500, url: String(url), text: async () => '' })
   assert.equal(await __test__.resolveRedirectedSourceUrl(new URL('https://example.com/')), null)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/commands/import.test.js` around lines 126 - 128, Remove the duplicated
globalThis.fetch override in the resolveRedirectedSourceUrl non-OK response
test, leaving a single assignment before the assertion.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/commands/import.test.js`:
- Around line 126-128: Remove the duplicated globalThis.fetch override in the
resolveRedirectedSourceUrl non-OK response test, leaving a single assignment
before the assertion.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 55db4c7f-a819-4258-9336-6d400595d760

📥 Commits

Reviewing files that changed from the base of the PR and between 7c5c920 and 31a95b9.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • package.json
  • src/commands/import.js
  • src/commands/import.test.js
  • src/prompts/index.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • readmeio/ai (manual)
  • readmeio/gitto (manual)
  • readmeio/markdown (manual)
  • readmeio/readme (manual)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant