[PR #1273/4acf7775 backport][3.27] Fix provenance sync for Pulp User publishers#1274
Open
patchback[bot] wants to merge 2 commits into
Open
Conversation
* Fix provenance sync to use Pulp's extended Provenance model Sync was validating provenance with pypi_attestations.Provenance, which rejects Pulp User publishers created during upload. Use the extended model from pulp_python.app.provenance instead. (cherry picked from commit 4acf777)
2 tasks
gerrod3
previously approved these changes
Jul 14, 2026
The 3.27 branch lacks the parallel package substitution tests from main, but test_content_crud still uploads aiohttp bytes as shelf-reader-0.1.tar.gz and leaves incorrect global content behind. Split that case into its own non-parallel test with orphan cleanup, and run the brittle pypi JSON assertions outside the parallel suite with delete_orphans_pre. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
multi-commit
jobselko
reviewed
Jul 15, 2026
|
|
||
| @pytest.mark.parallel | ||
| def test_pypi_json(python_remote_factory, python_repo_with_sync, python_distribution_factory): | ||
| def test_pypi_json( |
Member
There was a problem hiding this comment.
Should we add the fixes for test_pypi_json and test_pypi_json_content_app to other branches (or at least to the main) as well?
| assert task.created_resources[0] == content.pulp_href | ||
|
|
||
| # Test upload same filename w/ different artifact | ||
| monitor_task(python_bindings.RepositoriesPythonApi.delete(repo.pulp_href).task) |
Member
There was a problem hiding this comment.
Why do we need the change in test_content_crud? CI for the previous commit was failing only for test_pypi_json and test_pypi_json_content_app. Is this fix for sth else? If so, should it go at least into main?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1273 as merged into main (4acf777).
Summary
Provenancefrompulp_python.app.provenancein the sync task instead ofpypi_attestations, so sync accepts attestations withPulp Userpublishers created during uploadTest plan
test_sync_pulp_created_provenancefunctional testoci-env test functional -p python pulp_python/tests/functional/api/test_attestations.py::test_sync_pulp_created_provenance -vAssisted-by: Cursor
Made with Cursor