Fix provenance sync for Pulp User publishers#1273
Merged
Merged
Conversation
github-actions
Bot
added
no-issue
multi-commit
dkliban
reviewed
Jul 14, 2026
| provenance=True, | ||
| includes=[f"twine=={twine_package.version}"], | ||
| ) | ||
| dest_repo = python_repo_with_sync(remote=remote) |
Member
There was a problem hiding this comment.
@gerrod3 would it be better to test syncing from a different domain? my concern is that the Provenance content unit is just reused so validation doesn't happen in the test
Sync was validating provenance with pypi_attestations.Provenance, which rejects Pulp User publishers created during upload. Use the extended model from pulp_python.app.provenance instead. Add a cross-domain functional test that uploads attestations in one domain and syncs provenance into a repository in another. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
gerrod3
force-pushed
the
fix/pulp-attestation-sync
branch
from
1ddc48d to
bab78b7
Compare
github-actions
Bot
removed
multi-commit
domain_factory already skips when domains are disabled. Assisted-by: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
multi-commit
dkliban
approved these changes
Jul 14, 2026
Backport to 3.27: 💚 backport PR created✅ Backport PR branch: Backported as #1274 🤖 @patchback |
2 tasks
Backport to 3.31: 💚 backport PR created✅ Backport PR branch: Backported as #1275 🤖 @patchback |
2 tasks
gerrod3
added a commit
that referenced
this pull request
Jul 15, 2026
* Fix provenance sync to use Pulp's extended Provenance model Sync was validating provenance with pypi_attestations.Provenance, which rejects Pulp User publishers created during upload. Use the extended model from pulp_python.app.provenance instead. (cherry picked from commit 4acf777)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provenancefrompulp_python.app.provenancein the sync task instead ofpypi_attestations, so sync accepts attestations withPulp Userpublishers created during uploadTest plan
test_sync_pulp_created_provenancefunctional testoci-env test functional -p python pulp_python/tests/functional/api/test_attestations.py::test_sync_pulp_created_provenance -vAssisted-by: Cursor
Made with Cursor