Skip to content

reuse add_book_to_title to promote books without title - #464

Merged
elfkuzco merged 1 commit into
mainfrom
promote-books-without-title
Jul 31, 2026
Merged

reuse add_book_to_title to promote books without title#464
elfkuzco merged 1 commit into
mainfrom
promote-books-without-title

Conversation

@elfkuzco

Copy link
Copy Markdown
Contributor

Changes

  • move logic to add_book_to_title to db/book module and reuse when we are applying action to create title. This action is never attached with other actions that restore title or update title metadata because title never exists at that point. This way, when we are adding book to title, book filename is computed from filename along with other helpful events that get logged when book is newly added to title

This fixes #463

@elfkuzco elfkuzco self-assigned this Jul 31, 2026
@elfkuzco
elfkuzco requested a review from benoit74 July 31, 2026 13:50
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (5f8d26a) to head (33cc1ec).

Files with missing lines Patch % Lines
backend/src/cms_backend/db/book.py 69.23% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   81.04%   81.12%   +0.08%     
==========================================
  Files          65       64       -1     
  Lines        3883     3879       -4     
  Branches      472      472              
==========================================
  Hits         3147     3147              
+ Misses        583      581       -2     
+ Partials      153      151       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfkuzco
elfkuzco merged commit 30b5372 into main Jul 31, 2026
4 of 5 checks passed
@elfkuzco
elfkuzco deleted the promote-books-without-title branch July 31, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promoting a book from quarantine did not correctly computed the correct filename

2 participants