Promoting a book from quarantine did not correctly computed the correct filename

[benoit74]

Yesterday, we promoted two books which were blocked in quarantine with "Pending title". We just detected that the ZIM files have not been renamed at all:

• https://cms.openzim.org/book/6c38dade-f569-fb59-4116-348b477c4f50
• https://cms.openzim.org/book/83fe4294-6296-9e74-daa7-99be7d2511f3

@elfkuzco please fix the bug (obviously) but also fix the situation in production (you can unpromote manually from CMS UI for instance, not sure it is going to help). Probably worth to first fix the situation in production so that we stop publishing ZIMs with wrong filenames in the Kiwix catalog.

[elfkuzco]

I don't think unpromoting book will solve the filename issue but I have written this helper script (not sure if it qualifies as a maint-script since it's just for the two cases). Unpromoting book will only move it back to staging but it won't change it's filename. With logic in #464 , calling add_book_to_tilte will generate new name for book and update book events

from uuid import UUID
from cms_backend.db import Session
from cms_backend import logger
from cms_backend.db.book import add_book_to_title, get_book


def main():
    book_ids = [
        "6c38dade-f569-fb59-4116-348b477c4f50",
        "83fe4294-6296-9e74-daa7-99be7d2511f3",
    ]
    with Session() as session:
        for book_id in book_ids:
            book = get_book(session, UUID(book_id))
            if book.title is None:
                logger.error(f"Book {book_id} has no title.")
                continue

            title = book.title
            book.title = None
            add_book_to_title(session, book, title)
            session.commit()

if __name__ == "__main__":
    main()

[rgaudin]

Reopening because those files are still exposed in the catalog. Not sure if you'd prefer a different issue elsewhere

❯ curl -s 'https://opds.library.kiwix.org/catalog/v2/entries?name=avanti_hi_straight-lines' |grep application/x-zim
    <link rel="http://opds-spec.org/acquisition/open-access" type="application/x-zim" href="https://lb.download.kiwix.org/zim/videos/6c38dade-f569-fb59-4116-348b477c4f50.zim.meta4" length="195110912" />

❯ curl -s 'https://opds.library.kiwix.org/catalog/v2/entries?name=avanti_hi_vector-and-calculus' |grep application/x-zim
    <link rel="http://opds-spec.org/acquisition/open-access" type="application/x-zim" href="https://lb.download.kiwix.org/zim/videos/83fe4294-6296-9e74-daa7-99be7d2511f3.zim.meta4" length="247476224" />

[elfkuzco]

It's okay. Working on it already...

[benoit74]

Reading our chat discussions again, and having a new look at #466, I'm still not convinced we are on the right path.

With #464, we've fixed the issue which caused this bad situation.

With the small script you shared in #463 (comment), we've achieved to create what we want in CMS DB.

The only problem is the the shuttle does not support the situation below:

• current location: warehouse A, path A, filename A
• target location: warehouse A, path A, filename B

This looks like a totally legit DB content (it is even valid from DB schema perspective since the script achieved to save this content in DB) and a totally legit file move operation (we could implement other operations which might lead to such situations in the future for other reasons).

You said that we have a problem because BookLocation primary key is "book_id, warehouse_id and path". This is wrong, BookLocation primary key is "book_id, warehouse_id, path and status". Which is perfectly fine here, and perfectly correct.

So IMHO the only thing we have to fix is shuttle code which does not correctly take into account the book location filename because we made wrong assumptions when writing the code. Let's discuss this live if needed.

[benoit74]

Looks good now:

> curl -s 'https://opds.library.kiwix.org/catalog/v2/entries?name=avanti_hi_straight-lines' |grep application/x-zim
    <link rel="http://opds-spec.org/acquisition/open-access" type="application/x-zim" href="https://lb.download.kiwix.org/zim/videos/avanti_hi_straight-lines_2026-07.zim.meta4" length="195110912" />

> curl -s 'https://opds.library.kiwix.org/catalog/v2/entries?name=avanti_hi_vector-and-calculus' |grep application/x-zim
    <link rel="http://opds-spec.org/acquisition/open-access" type="application/x-zim" href="https://lb.download.kiwix.org/zim/videos/avanti_hi_vector-and-calculus_2026-07.zim.meta4" length="247476224" />