Skip to content

Enforce async a11y assertions and scope checks to <tab-container> in tests #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuliu-dev merged 2 commits into from
Jul 28, 2026
Merged

Enforce async a11y assertions and scope checks to <tab-container> in tests #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc29ba
Initial plan
Copilot Jul 27, 2026
8e4124b
Fix async accessibility assertions in tests
Copilot Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 38 additions & 25 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,22 @@ describe('tab-container', function () {
</div>
</tab-container>
`
tabContainer = document.querySelector('tab-container')
tabs = Array.from(document.querySelectorAll('button'))
panels = Array.from(document.querySelectorAll('[role="tabpanel"]'))
})

afterEach(function () {
afterEach(async function () {
// Check to make sure we still have accessible markup after the test finishes running.
expect(document.body).to.be.accessible()

document.body.innerHTML = ''
try {
await expect(tabContainer).to.be.accessible()
} finally {
document.body.innerHTML = ''
}
})

it('has accessible markup', function () {
expect(document.body).to.be.accessible()
return expect(tabContainer).to.be.accessible()
})

it('the second tab is still selected', function () {
Expand All @@ -126,19 +129,22 @@ describe('tab-container', function () {
</div>
</tab-container>
`
tabContainer = document.querySelector('tab-container')
tabs = Array.from(document.querySelectorAll('button'))
panels = Array.from(document.querySelectorAll('[role="tabpanel"]'))
})

afterEach(function () {
afterEach(async function () {
// Check to make sure we still have accessible markup after the test finishes running.
expect(document.body).to.be.accessible()

document.body.innerHTML = ''
try {
await expect(tabContainer).to.be.accessible()
} finally {
document.body.innerHTML = ''
}
})

it('has accessible markup', function () {
expect(document.body).to.be.accessible()
return expect(tabContainer).to.be.accessible()
})

it('the second tab is still selected', function () {
Expand Down Expand Up @@ -175,15 +181,17 @@ describe('tab-container', function () {
tabContainer.addEventListener('tab-container-changed', e => events.push(e))
})

afterEach(function () {
afterEach(async function () {
// Check to make sure we still have accessible markup after the test finishes running.
expect(document.body).to.be.accessible()

document.body.innerHTML = ''
try {
await expect(tabContainer).to.be.accessible()
} finally {
document.body.innerHTML = ''
}
})

it('has accessible markup', function () {
expect(document.body).to.be.accessible()
return expect(tabContainer).to.be.accessible()
})

it('click works and `tab-container-changed` event is dispatched with correct index', function () {
Expand Down Expand Up @@ -404,15 +412,17 @@ describe('tab-container', function () {
tabContainer.addEventListener('tab-container-changed', e => events.push(e))
})

afterEach(function () {
afterEach(async function () {
// Check to make sure we still have accessible markup after the test finishes running.
expect(document.body).to.be.accessible()

document.body.innerHTML = ''
try {
await expect(tabContainer).to.be.accessible()
} finally {
document.body.innerHTML = ''
}
})

it('has accessible markup', function () {
expect(document.body).to.be.accessible()
return expect(tabContainer).to.be.accessible()
})

it('only switches closest tab-containers on click', () => {
Expand Down Expand Up @@ -710,19 +720,22 @@ describe('tab-container', function () {
</div>
</tab-container>
`
tabContainer = document.querySelector('tab-container')
tabs = Array.from(document.querySelectorAll('button'))
panels = Array.from(document.querySelectorAll('[role="tabpanel"]'))
})

afterEach(function () {
afterEach(async function () {
// Check to make sure we still have accessible markup after the test finishes running.
expect(document.body).to.be.accessible()

document.body.innerHTML = ''
try {
await expect(tabContainer).to.be.accessible()
} finally {
document.body.innerHTML = ''
}
})

it('has accessible markup', function () {
expect(document.body).to.be.accessible()
return expect(tabContainer).to.be.accessible()
})

it('the second tab is still selected', function () {
Expand Down
Loading