Enforce async a11y assertions and scope checks to <tab-container> in tests - #121
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix accessibility test results handling
Enforce async a11y assertions and scope checks to Jul 27, 2026
<tab-container> in tests
liuliu-dev
marked this pull request as ready for review
July 28, 2026 17:28
liuliu-dev
approved these changes
Jul 28, 2026
There was a problem hiding this comment.
Pull request overview
Ensures accessibility checks are awaited and scoped to the component fixture.
Changes:
- Await asynchronous accessibility assertions with guaranteed cleanup.
- Scope axe checks to
<tab-container>. - Initialize fixture references where required.
Show a summary per file
| File | Description |
|---|---|
test/test.js |
Corrects accessibility assertion lifecycle and scope. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessibility assertions in
test/test.jswere usingexpect(...).to.be.accessible()without awaiting/returning the async result, so axe failures could be dropped. After fixing that, body-level checks were over-broad and failedregionexpectations unrelated to the component under test.Assertion lifecycle: make async checks observable
afterEachhooks toasyncandawaitthe a11y assertion.try/finallyso DOM cleanup always runs.it('has accessible markup', ...)so test runners correctly track failures.Assertion scope: test the component, not page layout
document.bodyto the fixture’stabContainerelement.tabContainerbefore assertions.