Skip to content

Handle scp-style SSH remotes correctly in git-mem source add #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: feature/multi-source
Choose a base branch
from
Draft

Handle scp-style SSH remotes correctly in git-mem source add #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7746c0
Initial plan
Copilot Jul 13, 2026
e526d4f
fix: treat scp-style SSH source URLs as remote repos
Copilot Jul 13, 2026
85dceb1
test: avoid source name reuse in scp URL checks
Copilot Jul 13, 2026
9fa26ca
refactor: tighten scp-style SSH source URL pattern
Copilot Jul 13, 2026
71776bb
test: use distinct SSH URL fixtures for source-add checks
Copilot Jul 13, 2026
fe922db
fix: prefer local repos before URL pattern matching for sources
Copilot Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions git-mem
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,21 +913,23 @@ cmd_source() {

mkdir -p "$GIT_MEMORY_SOURCES_DIR"
local dest="$GIT_MEMORY_SOURCES_DIR/$name"
local real_path
real_path=$(realpath "$location" 2>/dev/null || echo "$location")
local primary_real
primary_real=$(realpath "$GIT_MEMORY_DIR" 2>/dev/null || echo "$GIT_MEMORY_DIR")

if [[ "$location" =~ ^(https?|git|ssh):// ]]; then
[[ "$real_path" == "$primary_real" ]] && die "Cannot add primary memory store as a source"

if [[ -d "$real_path/.git" ]]; then
# Local path — symlink into sources dir
ln -s "$real_path" "$dest" || die "Symlink failed"
elif [[ "$location" =~ ^(https?|git|ssh):// || "$location" =~ ^[a-zA-Z0-9._-]+@[a-zA-Z0-9._-]+:.+ ]]; then
# URL — clone into sources dir
[[ -e "$dest" ]] && die "Directory already exists: $dest"
echo "Cloning $location..."
git clone "$location" "$dest" 2>&1 || die "Clone failed"
else
# Local path — symlink into sources dir
local real_path
real_path=$(realpath "$location" 2>/dev/null || echo "$location")
local primary_real
primary_real=$(realpath "$GIT_MEMORY_DIR" 2>/dev/null || echo "$GIT_MEMORY_DIR")
[[ "$real_path" == "$primary_real" ]] && die "Cannot add primary memory store as a source"
[[ ! -d "$real_path/.git" ]] && die "Not a git repository: $real_path"
ln -s "$real_path" "$dest" || die "Symlink failed"
die "Not a git repository: $real_path"
fi

local count
Expand Down
4 changes: 4 additions & 0 deletions tests/test-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ assert_exit_0 "add local source (hermes)" bash "$GIT_MEM" source add her
assert_exit_nonzero "add duplicate name fails" bash "$GIT_MEM" source add team /tmp/git-mem-src-team-$$
assert_exit_nonzero "add primary as source fails" bash "$GIT_MEM" source add mine "$GIT_MEMORY_DIR"
assert_exit_nonzero "reserved name 'mine' rejected" bash "$GIT_MEM" source add mine /tmp/git-mem-src-team-$$
assert_output_contains "scp-style SSH URL treated as remote clone" "Clone failed" \
bash "$GIT_MEM" source add sshremote1 git@127.0.0.1:/tmp/git-mem-nonexistent-a-$$
assert_output_not_contains "scp-style SSH URL not treated as local path" "Not a git repository" \
bash "$GIT_MEM" source add sshremote2 git@127.0.0.1:/tmp/git-mem-nonexistent-b-$$

# Verify symlinks created
[[ -L "$GIT_MEMORY_SOURCES_DIR/team" ]] && pass "team is a symlink" || fail "team symlink missing"
Expand Down