Draft
Handle scp-style SSH remotes correctly in git-mem source add#3
git-mem source add#3Conversation
Copilot
AI
changed the title
[WIP] Review current branch for merge readiness
Handle scp-style SSH remotes correctly in Jul 13, 2026
git-mem source add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge-readiness review surfaced a functional blocker:
source addmisclassified common scp-style Git remotes (git@host:org/repo.git) as local paths and failed withNot a git repository. This PR updates source classification so valid SSH remotes follow the clone path while preserving local-repo behavior.Source classification fix
cmd_source addnow resolves and checks local git repos first (<path>/.git), then treats URL-like inputs (including scp-styleuser@host:path) as clone targets.Regression coverage
tests/test-source.shwith scp-style SSH cases to assert:Clone failedon unreachable host),Not a git repository) is not emitted for that path.Original prompt