-
Notifications
You must be signed in to change notification settings - Fork 51
Added the skeleton projects for EF #5607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,066
−3
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e7424f2
Added the skeleton projects for EF
johnsimons 20898a1
Fixing tests
johnsimons d85d4ec
Fixing casing to match existing naming pattern
johnsimons 01a2285
Rename failures
johnsimons 0461db0
Add .editorconfig for EFCore persistence projects
johnsimons 09a60ee
Warn about incomplete EFCore persistence implementations
johnsimons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/ServiceControl.Persistence.EFCore.PostgreSql/.editorconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [*.cs] | ||
|
|
||
| # Justification: ServiceControl app has no synchronization context | ||
| dotnet_diagnostic.CA2007.severity = none | ||
|
|
||
| # Disable style rules for auto-generated EF migrations | ||
| [Migrations/**.cs] | ||
| dotnet_diagnostic.IDE0065.severity = none | ||
| generated_code = true |
32 changes: 32 additions & 0 deletions
32
src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlPersistence.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| namespace ServiceControl.Persistence.EFCore.PostgreSql; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| class PostgreSqlPersistence(PostgreSqlPersisterSettings settings) : BasePersistence, IPersistence | ||
| { | ||
| public void AddPersistence(IServiceCollection services) | ||
| { | ||
| RegisterSettings(services); | ||
| ConfigureDbContext(services); | ||
| RegisterDataStores(services); | ||
| } | ||
|
|
||
| public void AddInstaller(IServiceCollection services) | ||
| { | ||
| RegisterSettings(services); | ||
| ConfigureDbContext(services); | ||
| } | ||
|
|
||
| void RegisterSettings(IServiceCollection services) | ||
| { | ||
| services.AddSingleton<PersistenceSettings>(settings); | ||
| services.AddSingleton<EFPersisterSettings>(settings); | ||
| services.AddSingleton(settings); | ||
| } | ||
|
|
||
| void ConfigureDbContext(IServiceCollection services) => | ||
| services.AddPooledDbContextFactory<PostgreSqlServiceControlDbContext>(options => | ||
| options.UseNpgsql(settings.ConnectionString, npgsql => npgsql.CommandTimeout(settings.CommandTimeout))); | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlPersistenceConfiguration.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| namespace ServiceControl.Persistence.EFCore.PostgreSql; | ||
|
|
||
| using Microsoft.Extensions.Logging; | ||
| using ServiceControl.Infrastructure; | ||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| class PostgreSqlPersistenceConfiguration : EFPersistenceConfigurationBase | ||
| { | ||
| public override IPersistence Create(PersistenceSettings settings) | ||
| { | ||
| // Temporary until the persister is fully implemented | ||
| LoggerUtil.CreateStaticLogger<PostgreSqlPersistenceConfiguration>() | ||
| .LogError("The PostgreSQL persistence is still under development and is not ready for use"); | ||
|
|
||
| return new PostgreSqlPersistence((PostgreSqlPersisterSettings)settings); | ||
| } | ||
|
|
||
| protected override EFPersisterSettings CreateSettings(string connectionString) => | ||
| new PostgreSqlPersisterSettings { ConnectionString = connectionString }; | ||
| } |
7 changes: 7 additions & 0 deletions
7
src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlPersisterSettings.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace ServiceControl.Persistence.EFCore.PostgreSql; | ||
|
|
||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| public class PostgreSqlPersisterSettings : EFPersisterSettings | ||
| { | ||
| } |
8 changes: 8 additions & 0 deletions
8
src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlServiceControlDbContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| namespace ServiceControl.Persistence.EFCore.PostgreSql; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using ServiceControl.Persistence.EFCore.DbContexts; | ||
|
|
||
| public class PostgreSqlServiceControlDbContext(DbContextOptions<PostgreSqlServiceControlDbContext> options) : ServiceControlDbContext(options) | ||
| { | ||
| } |
21 changes: 21 additions & 0 deletions
21
src/ServiceControl.Persistence.EFCore.PostgreSql/PostgreSqlServiceControlDbContextFactory.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| namespace ServiceControl.Persistence.EFCore.PostgreSql; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.EntityFrameworkCore.Design; | ||
|
|
||
| /// <summary> | ||
| /// Design-time factory used by the dotnet-ef tooling (e.g. dotnet ef migrations add). | ||
| /// </summary> | ||
| public class PostgreSqlServiceControlDbContextFactory : IDesignTimeDbContextFactory<PostgreSqlServiceControlDbContext> | ||
| { | ||
| public PostgreSqlServiceControlDbContext CreateDbContext(string[] args) | ||
| { | ||
| var connectionString = Environment.GetEnvironmentVariable("SERVICECONTROL_DATABASE_CONNECTIONSTRING") | ||
| ?? "Host=localhost;Port=5432;Database=servicecontrol;Username=postgres;Password=postgres"; | ||
|
|
||
| var optionsBuilder = new DbContextOptionsBuilder<PostgreSqlServiceControlDbContext>(); | ||
| optionsBuilder.UseNpgsql(connectionString); | ||
|
|
||
| return new PostgreSqlServiceControlDbContext(optionsBuilder.Options); | ||
| } | ||
| } |
37 changes: 37 additions & 0 deletions
37
...Control.Persistence.EFCore.PostgreSql/ServiceControl.Persistence.EFCore.PostgreSql.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | ||
| <DisableTransitiveProjectReferences>true</DisableTransitiveProjectReferences> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Private=false & ExcludeAssets=runtime prevent repeatedly including binary dependencies of ServiceControl.Persistence and its dependencies in each persister directory --> | ||
| <ProjectReference Include="../ServiceControl.Configuration/ServiceControl.Configuration.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| <ProjectReference Include="../ServiceControl.Infrastructure/ServiceControl.Infrastructure.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| <ProjectReference Include="../ServiceControl.Persistence/ServiceControl.Persistence.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Not Private=false or ExcludeAssets because the shared EF Core assembly ships inside this persister's folder --> | ||
| <ProjectReference Include="../ServiceControl.Persistence.EFCore/ServiceControl.Persistence.EFCore.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Design-time only, for dotnet-ef tooling. Debug-only so it (and its Roslyn dependency tail) stays out of the shipped Release artifact --> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.Design" PrivateAssets="all" Condition="'$(Configuration)' == 'Debug'" /> | ||
| <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="persistence.manifest" CopyToOutputDirectory="PreserveNewest" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Artifact Include="$(OutputPath)" DestinationFolder="$(ArtifactsPath)Particular.ServiceControl/Persisters/PostgreSQL" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
25 changes: 25 additions & 0 deletions
25
src/ServiceControl.Persistence.EFCore.PostgreSql/persistence.manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "Name": "PostgreSQL", | ||
| "DisplayName": "PostgreSQL", | ||
| "Description": "PostgreSQL ServiceControl persister", | ||
| "AssemblyName": "ServiceControl.Persistence.EFCore.PostgreSql", | ||
| "TypeName": "ServiceControl.Persistence.EFCore.PostgreSql.PostgreSqlPersistenceConfiguration, ServiceControl.Persistence.EFCore.PostgreSql", | ||
| "Settings": [ | ||
| { | ||
| "Name": "ServiceControl/Database/ConnectionString", | ||
| "Mandatory": true | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/Database/CommandTimeout", | ||
| "Mandatory": false | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/MessageBody/StoragePath", | ||
| "Mandatory": false | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/MessageBody/MinCompressionSize", | ||
| "Mandatory": false | ||
| } | ||
| ] | ||
| } | ||
9 changes: 9 additions & 0 deletions
9
src/ServiceControl.Persistence.EFCore.SqlServer/.editorconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [*.cs] | ||
|
|
||
| # Justification: ServiceControl app has no synchronization context | ||
| dotnet_diagnostic.CA2007.severity = none | ||
|
|
||
| # Disable style rules for auto-generated EF migrations | ||
| [Migrations/**.cs] | ||
| dotnet_diagnostic.IDE0065.severity = none | ||
| generated_code = true |
37 changes: 37 additions & 0 deletions
37
...ceControl.Persistence.EFCore.SqlServer/ServiceControl.Persistence.EFCore.SqlServer.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | ||
| <DisableTransitiveProjectReferences>true</DisableTransitiveProjectReferences> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Private=false & ExcludeAssets=runtime prevent repeatedly including binary dependencies of ServiceControl.Persistence and its dependencies in each persister directory --> | ||
| <ProjectReference Include="../ServiceControl.Configuration/ServiceControl.Configuration.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| <ProjectReference Include="../ServiceControl.Infrastructure/ServiceControl.Infrastructure.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| <ProjectReference Include="../ServiceControl.Persistence/ServiceControl.Persistence.csproj" Private="false" ExcludeAssets="runtime" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Not Private=false or ExcludeAssets because the shared EF Core assembly ships inside this persister's folder --> | ||
| <ProjectReference Include="../ServiceControl.Persistence.EFCore/ServiceControl.Persistence.EFCore.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- Design-time only, for dotnet-ef tooling. Debug-only so it (and its Roslyn dependency tail) stays out of the shipped Release artifact --> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.Design" PrivateAssets="all" Condition="'$(Configuration)' == 'Debug'" /> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="persistence.manifest" CopyToOutputDirectory="PreserveNewest" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Artifact Include="$(OutputPath)" DestinationFolder="$(ArtifactsPath)Particular.ServiceControl/Persisters/SQLServer" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
32 changes: 32 additions & 0 deletions
32
src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerPersistence.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| namespace ServiceControl.Persistence.EFCore.SqlServer; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| class SqlServerPersistence(SqlServerPersisterSettings settings) : BasePersistence, IPersistence | ||
| { | ||
| public void AddPersistence(IServiceCollection services) | ||
| { | ||
| RegisterSettings(services); | ||
| ConfigureDbContext(services); | ||
| RegisterDataStores(services); | ||
| } | ||
|
|
||
| public void AddInstaller(IServiceCollection services) | ||
| { | ||
| RegisterSettings(services); | ||
| ConfigureDbContext(services); | ||
| } | ||
|
|
||
| void RegisterSettings(IServiceCollection services) | ||
| { | ||
| services.AddSingleton<PersistenceSettings>(settings); | ||
| services.AddSingleton<EFPersisterSettings>(settings); | ||
| services.AddSingleton(settings); | ||
| } | ||
|
|
||
| void ConfigureDbContext(IServiceCollection services) => | ||
| services.AddPooledDbContextFactory<SqlServerServiceControlDbContext>(options => | ||
| options.UseSqlServer(settings.ConnectionString, sqlServer => sqlServer.CommandTimeout(settings.CommandTimeout))); | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerPersistenceConfiguration.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| namespace ServiceControl.Persistence.EFCore.SqlServer; | ||
|
|
||
| using Microsoft.Extensions.Logging; | ||
| using ServiceControl.Infrastructure; | ||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| class SqlServerPersistenceConfiguration : EFPersistenceConfigurationBase | ||
| { | ||
| public override IPersistence Create(PersistenceSettings settings) | ||
| { | ||
| // Temporary until the persister is fully implemented | ||
| LoggerUtil.CreateStaticLogger<SqlServerPersistenceConfiguration>() | ||
| .LogError("The SQL Server persistence is still under development and is not ready for use"); | ||
|
|
||
| return new SqlServerPersistence((SqlServerPersisterSettings)settings); | ||
| } | ||
|
|
||
| protected override EFPersisterSettings CreateSettings(string connectionString) => | ||
| new SqlServerPersisterSettings { ConnectionString = connectionString }; | ||
| } |
7 changes: 7 additions & 0 deletions
7
src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerPersisterSettings.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| namespace ServiceControl.Persistence.EFCore.SqlServer; | ||
|
|
||
| using ServiceControl.Persistence.EFCore.Abstractions; | ||
|
|
||
| public class SqlServerPersisterSettings : EFPersisterSettings | ||
| { | ||
| } |
8 changes: 8 additions & 0 deletions
8
src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerServiceControlDbContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| namespace ServiceControl.Persistence.EFCore.SqlServer; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using ServiceControl.Persistence.EFCore.DbContexts; | ||
|
|
||
| public class SqlServerServiceControlDbContext(DbContextOptions<SqlServerServiceControlDbContext> options) : ServiceControlDbContext(options) | ||
| { | ||
| } |
21 changes: 21 additions & 0 deletions
21
src/ServiceControl.Persistence.EFCore.SqlServer/SqlServerServiceControlDbContextFactory.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| namespace ServiceControl.Persistence.EFCore.SqlServer; | ||
|
|
||
| using Microsoft.EntityFrameworkCore; | ||
| using Microsoft.EntityFrameworkCore.Design; | ||
|
|
||
| /// <summary> | ||
| /// Design-time factory used by the dotnet-ef tooling (e.g. dotnet ef migrations add). | ||
| /// </summary> | ||
| public class SqlServerServiceControlDbContextFactory : IDesignTimeDbContextFactory<SqlServerServiceControlDbContext> | ||
| { | ||
| public SqlServerServiceControlDbContext CreateDbContext(string[] args) | ||
| { | ||
| var connectionString = Environment.GetEnvironmentVariable("SERVICECONTROL_DATABASE_CONNECTIONSTRING") | ||
| ?? "Server=localhost;Database=ServiceControl;Trusted_Connection=True;TrustServerCertificate=True"; | ||
|
|
||
| var optionsBuilder = new DbContextOptionsBuilder<SqlServerServiceControlDbContext>(); | ||
| optionsBuilder.UseSqlServer(connectionString); | ||
|
|
||
| return new SqlServerServiceControlDbContext(optionsBuilder.Options); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/ServiceControl.Persistence.EFCore.SqlServer/persistence.manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "Name": "SQLServer", | ||
| "DisplayName": "SQL Server", | ||
| "Description": "SQL Server ServiceControl persister", | ||
| "AssemblyName": "ServiceControl.Persistence.EFCore.SqlServer", | ||
| "TypeName": "ServiceControl.Persistence.EFCore.SqlServer.SqlServerPersistenceConfiguration, ServiceControl.Persistence.EFCore.SqlServer", | ||
| "Settings": [ | ||
| { | ||
| "Name": "ServiceControl/Database/ConnectionString", | ||
| "Mandatory": true | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/Database/CommandTimeout", | ||
| "Mandatory": false | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/MessageBody/StoragePath", | ||
| "Mandatory": false | ||
| }, | ||
| { | ||
| "Name": "ServiceControl/MessageBody/MinCompressionSize", | ||
| "Mandatory": false | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| [*.cs] | ||
|
|
||
| # Justification: ServiceControl app has no synchronization context | ||
| dotnet_diagnostic.CA2007.severity = none | ||
|
|
||
| # Disable style rules for auto-generated EF migrations | ||
| [Migrations/**.cs] | ||
| dotnet_diagnostic.IDE0065.severity = none | ||
| generated_code = true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
SqlvsSQLcasing be standardised onSql?Note that we already use PostgreSql elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed