Added the skeleton projects for EF#5607
Merged
Merged
Conversation
johnsimons
force-pushed
the
john/ef_projects
branch
from
cce5959 to
e7424f2
Compare
rbev
approved these changes
Jul 16, 2026
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "Name": "PostgreSQL", | |||
Contributor
There was a problem hiding this comment.
Should Sql vs SQL casing be standardised on Sql?
Note that we already use PostgreSql elsewhere.
|
|
||
| protected abstract EFPersisterSettings CreateSettings(string connectionString); | ||
|
|
||
| static T GetRequiredSetting<T>(SettingsRootNamespace settingsRootNamespace, string key) |
Contributor
There was a problem hiding this comment.
The raven persister makes these utility functions private functions in CreateSettings, is it worth being consistent?
johnsimons
force-pushed
the
john/ef_projects
branch
from
f535508 to
a6ac471
Compare
johnsimons
force-pushed
the
john/ef_projects
branch
from
a6ac471 to
01a2285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR adds the initial skeleton projects for EF.
These persisters are not yet enabled for public consumption.