Support for NaN coordinates in hashtable (for Delft3D) - #2780
Open
erikvansebille wants to merge 1 commit into
Open
Support for NaN coordinates in hashtable (for Delft3D)#2780erikvansebille wants to merge 1 commit into
erikvansebille wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working on Delft3D (#2774) and SWAN models, I realised that the hashtable construction does not properly take into account coordinate values that are NaN (as they are in Delft3D and SWAN, for non-existent grid cells). While the search went well, the construction didn't go well because xmin, ymin, xmax anx ymax were not correctly set. This PR fixes that, and thereby increases performance on #2774
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None