Add convert_delft3d_to_sgrid - #2774
Open
erikvansebille wants to merge 11 commits into
Open
Conversation
Delft3D padding is similar to NEMO, according to Figure 4.6 of https://content.oss.deltares.nl/delft3d4/Delft3D-FLOW_User_Manual.pdf
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
convert_delft3d_to_sgrid()function, to convert structured-grid netcdf output from Delft3D to SGrid, and use it in Parcels.Note that the interpolation method is currently set to XFreeslip, which may not be the best choice for this data on a Grid. However, we can't use the
CGrid_Velocity()interpolator as currently implemented in Parcels on the example data that I got from Port of Rotterdam), because theVELUandVELVvelocities are rotated to the east and north directions - where theCGrid_Velocity()interpolator expects unrotated velocities in theMandNdirections. I'm planning to talk to Deltares to see how we can fix thisNote that, at least for performance, this PR is blocked by #2780
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None