Updates copier template and adds example template#15
Conversation
0727953 to
9c61f24
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 77 87 +10
=========================================
+ Hits 77 87 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9c61f24 to
eaee76a
Compare
Matt-Carre
changed the title
b539bf5 to
1ea82fa
Compare
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
There was a problem hiding this comment.
Good work with the example template! Just a couple of things I have questions about
There was a problem hiding this comment.
Probably makes more sense to include in #16 instead
There was a problem hiding this comment.
Deleted from this branch now, thank you, forgot about this one!
| HOST=https://argo-workflows.workflows.diamond.ac.uk/ | ||
| IMAGE= | ||
| TOKEN= | ||
| NAMESPACE= | ||
| AUTH= |
There was a problem hiding this comment.
The code edits this file, right? I worry that having this tracked by version control will end up with a token getting committed & pushed by accident at some point. Might need reworking slightly...
There was a problem hiding this comment.
The code doesn't edit that file, it edits the file just called .env (specifically, at the path 'src/.env'), this is used as an example so people know what the .env requires - can re-do this if that would be better?
There was a problem hiding this comment.
Ah my mistake, sorry! Perhaps it'd be worth turning this into a readme explaining that, like how we do for the .env.local in the Workflows frontend?
There was a problem hiding this comment.
Good plan, thank you, and no problem!
| # from python_interface_to_workflows.prepare_to_submit import prepare_to_submit | ||
|
|
||
| # prepare_to_submit(True) |
There was a problem hiding this comment.
Are the commented out lines in the workflows for testing out submission? If so, do they need to remain in all the workflow templates or can they be removed?
There was a problem hiding this comment.
They are, but as this is being used as the template copy, I was thinking that we would want to include this to show how to submit workflows to users. Can delete if you'd like?
There was a problem hiding this comment.
My preference would be to have a more centralised way of doing this if possible, rather than having this written in comments on every template file, but it's up to you. If you do leave it in, I'd consider adding another comment line explaining what it's for
There was a problem hiding this comment.
Good idea - this functionality changes in the next branch, and its much more clear what happens there, so I think I'll just delete the comments in this PR
4fb156e to
1b28978
Compare
2 participants
No description provided.