feat(api): adds automatic keycloak verification#12
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 5 +2
Lines 22 77 +55
=========================================
+ Hits 22 77 +55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Matt-Carre
force-pushed
the
keycloak_auth
branch
5 times, most recently
from
June 29, 2026 13:35
384fc4a to
ba92fc2
Compare
Collaborator
Author
|
Not entirely sure how to test the "_open_auth_url" portion of the "return_key" function. Do you guys have any ideas? In the mean time, once this and the previous PR are approved, this will be moved to the auth folder, and will also delete the old get_token.py file. |
TBThomas56
reviewed
Jun 30, 2026
TBThomas56
reviewed
Jun 30, 2026
TBThomas56
reviewed
Jun 30, 2026
Matt-Carre
force-pushed
the
keycloak_auth
branch
11 times, most recently
from
July 1, 2026 11:21
f184967 to
47bccfa
Compare
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Collaborator
There was a problem hiding this comment.
Good work with the tests 👍 What's the process for using this auth mechanism? Or is that to come in future? I tried running a print(return_key(True)) but I only seem to get Client not found from keycloak
Matt-Carre
force-pushed
the
keycloak_auth
branch
from
July 13, 2026 12:25
47bccfa to
81e49e2
Compare
davehadley
previously approved these changes
Jul 16, 2026
Matt-Carre
force-pushed
the
keycloak_auth
branch
2 times, most recently
from
July 16, 2026 12:16
2d394ab to
591dcf2
Compare
Matt-Carre
force-pushed
the
keycloak_auth
branch
7 times, most recently
from
July 17, 2026 12:06
285ef58 to
b96d0d3
Compare
Collaborator
|
I think this is in need of splitting up. To me, it seems that there are three distinct things being added here, each of which should be its own PR:
If you could please have a go at separating, then this should be easier to get reviewed & merged |
Matt-Carre
force-pushed
the
keycloak_auth
branch
2 times, most recently
from
July 20, 2026 08:57
cfb5cf7 to
19a8efe
Compare
Matt-Carre
force-pushed
the
keycloak_auth
branch
from
July 20, 2026 08:58
19a8efe to
224b74e
Compare
JamesDoingStuff
left a comment
JamesDoingStuff
left a comment
Collaborator
There was a problem hiding this comment.
Successfully tested getting a token 👍 Couple of comments added, plus @davehadley's still need addressing
Matt-Carre
force-pushed
the
keycloak_auth
branch
2 times, most recently
from
July 21, 2026 11:01
fddbf3a to
1d4a7c5
Compare
Matt-Carre
force-pushed
the
keycloak_auth
branch
from
July 21, 2026 11:25
1d4a7c5 to
1d7dc29
Compare
Matt-Carre
force-pushed
the
keycloak_auth
branch
from
July 21, 2026 11:31
241489c to
2f54e60
Compare
TBThomas56
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds keycloak verification to the graphql file