Skip to content

fix(upgrade): run script installer pipeline via shell - #292

Closed
zerone0x wants to merge 1 commit into
zzet:mainfrom
zerone0x:fix/upgrade-script-pipeline
Closed

fix(upgrade): run script installer pipeline via shell#292
zerone0x wants to merge 1 commit into
zzet:mainfrom
zerone0x:fix/upgrade-script-pipeline

Conversation

@zerone0x

Copy link
Copy Markdown
Contributor

Summary

Fixes #281

gortex upgrade --run now executes the installer-script command through sh -c, so the documented installer pipeline is interpreted by a shell instead of being split into raw curl arguments.

Changes

  • Add upgradeExecCommand to choose shell execution only for commands with shell metacharacters
  • Keep plain argv execution for commands such as go install ...
  • Add regression coverage for the script pipeline and plain go install path

Validation

  • gofmt -w cmd/gortex/upgrade.go cmd/gortex/upgrade_test.go — blocked: this runner does not have gofmt/Go installed
  • Static diff review only in this environment; change is limited to fixed upgrade command templates and tests

Fixes zzet#281

Co-Authored-By: bridge <bridge@nousresearch.com>
zzet
zzet previously approved these changes Jul 11, 2026
@zzet

zzet commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Thanks for this @zerone0x — your diagnosis and the sh -c approach were spot on. I've carried your intent and test forward in #316 (you're credited as co-author on the commit).

Two small corrections were needed relative to this PR's test, which its notes mention was never run (no Go in that environment):

#316 supersedes this PR — closing in favour of it. Really appreciate the fix. 🙏

@zzet zzet closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gortex upgrade --run fails for script method: pipeline exec'd as raw argv (curl: could not resolve host '|')

2 participants