Skip to content

Support placeholders in style config options. - #154

Open
sigurdo wants to merge 2 commits into
xaverh:masterfrom
sigurdo:master
Open

Support placeholders in style config options.#154
sigurdo wants to merge 2 commits into
xaverh:masterfrom
sigurdo:master

Conversation

@sigurdo

@sigurdo sigurdo commented Jun 24, 2023

Copy link
Copy Markdown

Also increases the version number to a new minor version, since there are new features that might something.

I used #104 for reference implementation.

Also increases the version number to a new minor version, since there are new features that might something.
@sigurdo

sigurdo commented Jun 26, 2023

Copy link
Copy Markdown
Author

I'm sorry that my message appeared very disrespectful, especially considering that I just started using this extension and am completely new to the project. I also have generally very little knowledge of developing vscode extensions.

However, in my case, I store my clang-format style in a file style.clang-format at a location clang-format is not able to detect automatically. I therefore have to configure "clang-format.style" in .vscode/settings.json as "file:/absolute/path/to/style.clang-format". I think it would make sense to commit this to the git repo, but then I would prefer writing "file:${workspaceFolder}/path/to/style.clang-format", so that works on other computers. This is what my PR aims to support.

If you think the code is unproperly written for the extension, I would love to get feedback and will see if I can improve it.

@TheAlbertDev

Copy link
Copy Markdown

This functionality is critical and it is very important that it is merged. Thank you @sigurdo 🙌🏻

@troyliu0105

Copy link
Copy Markdown

Is this project dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants