refactor(test): migrate vite virtual module tests from e2e to integration - #17360
Merged
ematipico merged 3 commits intoJul 13, 2026
Merged
Conversation
|
fkatsuhiro
force-pushed
the
migrate/e2e-to-integration-vite-virtual-modules
branch
3 times, most recently
from
July 11, 2026 13:48
aaa3d66 to
b94dc04
Compare
fkatsuhiro
marked this pull request as ready for review
July 11, 2026 14:14
fkatsuhiro
force-pushed
the
migrate/e2e-to-integration-vite-virtual-modules
branch
from
July 11, 2026 14:21
b94dc04 to
e0e1094
Compare
ematipico
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
e2e tests are heavy and down the developer experience when run e2e test in local or CI/CD. To improve this, I want to migrate these tests from e2e to integration.
packages/astro/e2e/vite-virtual-modules.test.tsThis e2e test depends on only HTML element, no need to e2e test for this. So, it moved to integration test.
Testing
Reverted PR (#13902 ) changes temporarily to reproduce the issue in the tests, and then migrated the tests to integration.
Reproduce issue on test
Reflect #13902 in code testing
Related PR
#13902