Skip to content

refactor(test): migrate vite virtual module tests from e2e to integration - #17360

Merged
ematipico merged 3 commits into
withastro:mainfrom
fkatsuhiro:migrate/e2e-to-integration-vite-virtual-modules
Jul 13, 2026
Merged

refactor(test): migrate vite virtual module tests from e2e to integration#17360
ematipico merged 3 commits into
withastro:mainfrom
fkatsuhiro:migrate/e2e-to-integration-vite-virtual-modules

Conversation

@fkatsuhiro

@fkatsuhiro fkatsuhiro commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Changes

e2e tests are heavy and down the developer experience when run e2e test in local or CI/CD. To improve this, I want to migrate these tests from e2e to integration.

packages/astro/e2e/vite-virtual-modules.test.ts
This e2e test depends on only HTML element, no need to e2e test for this. So, it moved to integration test.

Testing

Reverted PR (#13902 ) changes temporarily to reproduce the issue in the tests, and then migrated the tests to integration.

Reproduce issue on test

スクリーンショット 2026-07-11 22 07 07

Reflect #13902 in code testing

スクリーンショット 2026-07-11 23 14 00

Related PR

#13902

@changeset-bot

changeset-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e0e1094

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Jul 11, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 21 untouched benchmarks


Comparing fkatsuhiro:migrate/e2e-to-integration-vite-virtual-modules (aaa3d66) with main (79a41e0)

Open in CodSpeed

@fkatsuhiro
fkatsuhiro force-pushed the migrate/e2e-to-integration-vite-virtual-modules branch 3 times, most recently from aaa3d66 to b94dc04 Compare July 11, 2026 13:48
@fkatsuhiro
fkatsuhiro marked this pull request as ready for review July 11, 2026 14:14
@fkatsuhiro
fkatsuhiro force-pushed the migrate/e2e-to-integration-vite-virtual-modules branch from b94dc04 to e0e1094 Compare July 11, 2026 14:21
@ematipico
ematipico merged commit 3048391 into withastro:main Jul 13, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants