fix(persist): order terminal lifecycle locks - #52
Open
wolfy-j wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FOR NO KEY UPDATEtoFOR UPDATERoot cause
A terminal update first took PostgreSQL's weaker row lock through
UPDATE dataflows, thendisable_terminal_txrequestedFOR UPDATE. A concurrent child commit could hold a foreign-keyKEY SHARElock on the workflow row while waiting to update it, producing the inverse wait and a deadlock.Verification
The full lint command still reports six unrelated pre-existing findings on clean v0.7.0; this change adds none.