feat: Track disableRemotePlayback Preference - #1889
Open
spuppo-mux wants to merge 4 commits into
Open
Conversation
|
@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6bb4ed3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #1800.
What
When a page author sets
disableRemotePlayback, the hls.js AirPlay bridge now respects it instead of unconditionally clearing it.How
HlsJsMediasnapshots the element'sdisableRemotePlaybackinattach(), before any engine attaches and while the value still reflects author intent, and hands it to the innerHlsJsOnlyMediadelegate (which hosts the AirPlay bridge) inload().The bridge only clears the flag when the author didn't set it:
This works uniformly for both platforms without a shared-plumbing change: in HTML the
<hlsjs-video disableRemotePlayback>attribute is mirrored onto the inner<video>at construction; in ReactdisableRemotePlaybackis a plain prop React applies to the<video>. Either way the facade reads it before hls.js overwrites it.Testing
airplay-bridge.test.ts: preservesdisableRemotePlaybackwhen the author set it; still enables AirPlay when it was set programmatically (no author intent).Note
Low Risk
Small, WebKit/AirPlay-specific behavior change with unit tests; default AirPlay behavior is unchanged when authors do not set
disableRemotePlayback.Overview
Hls.js MSE playback no longer forces AirPlay on when the page author set
disableRemotePlaybackon the video.HlsJsMediacopies the element’sdisableRemotePlaybackinto the MSE delegate asauthorDisableRemotePlaybackwhen the engine is created inload()(before attach/hls.js can change the flag). The AirPlay bridge only clearsdisableRemotePlaybackwhen that snapshot is false, so programmatic/hls.js-onlytruestill gets reset for the AirPlay picker.Tests cover explicit author opt-out vs programmatic-only
disableRemotePlayback.Reviewed by Cursor Bugbot for commit dff2865. Bugbot is set up for automated code reviews on this repo. Configure here.