Implement ID v4 version - #55
Open
Xynnn007 wants to merge 5 commits into
Open
Conversation
Xynnn007
force-pushed
the
ear-rev-4
branch
2 times, most recently
from
June 25, 2026 11:16
85e484d to
42a8f6a
Compare
Contributor
Author
|
I force pushed with my own repo rev. If veraison/rust-cmw#6 gets merged, I can update the rev. |
Xynnn007
force-pushed
the
ear-rev-4
branch
2 times, most recently
from
July 9, 2026 09:39
9832ee4 to
96f18a9
Compare
Xynnn007
force-pushed
the
ear-rev-4
branch
2 times, most recently
from
July 28, 2026 07:30
4987aa4 to
d917b40
Compare
Contributor
Author
|
Updated code and CI is green. PTAL @thomas-fossati @setrofim |
thomas-fossati
left a comment
thomas-fossati
left a comment
Contributor
There was a problem hiding this comment.
Excellent stuff, thanks very much @Xynnn007 !
Checking a couple of things with you before officially approving. See inline.
| [dependencies] | ||
| base64 = "0.22.1" | ||
| ciborium = "0.2.0" | ||
| cmw = { git = "https://github.com/veraison/rust-cmw.git", rev = "33d5ce2" } |
Contributor
There was a problem hiding this comment.
We'll need to ask @ionut-arm to release cmw before publishing this in crates.io, right?
Align wire claims and APIs with draft-04, including CMW evidence, expiration, nonce normalization, stricter optional-claim validation, and lenient handling of unknown claims. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Update the cargo-rdme README to match the revised lib.rs examples. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
Deserialization drops or caches claims the crate does not recognize instead of failing, which leaves no trace of what was skipped. Emit tracing events on those paths behind a new opt-in `log` feature, so users can debug unexpected tokens without the crate imposing a tracing dependency by default. Document the crate's features so the capability is discoverable from docs.rs and the README, build the docs.rs documentation with the feature enabled, and cover it in the CI feature matrix. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Ding, thanks very much for the follow up changes! 🚢 it! |
setrofim
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #54