fix(openclaw): make queued retains idempotent - #3143
Open
r266-tech wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3114.
What changed
RetainQueueJSONL rows and pass it through the typed client asoperationIdon every supported replay/versionbefore sends and flushes so old servers omit the wire field, while an unknown capability queues instead of risking a non-idempotent requestThis keeps compatibility with pre-0.8.6 servers and legacy queue rows while preventing a lost acknowledgement from creating duplicate durable memories and provider work.
Validation
npm test— 11 files, 294 tests passednpm run buildverify-generated-files)./scripts/hooks/lint.sh— all runnable tasks passed; the unrelated control-plane ESLint task could not load@eslint/jsfrom its local workspace installationThe regression coverage includes lost acknowledgements, restart replay, capability downgrade/upgrade, legacy rows, timer-driven flushes, stop during a version probe, stale hooks across restart, and per-item checkpointing after a partial batch acknowledgement.