fix(nano_banana_dashboard): inject current date into prompt and cache key#116
Open
natesilva wants to merge 1 commit into
Open
fix(nano_banana_dashboard): inject current date into prompt and cache key#116natesilva wants to merge 1 commit into
natesilva wants to merge 1 commit into
Conversation
… key When the plugin refreshes after midnight, source plugin data (e.g. calendar’s today_in_tz) may still contain yesterday's date. The Gemini prompt had no independent date reference, causing the LLM to render calendars and date-dependent visuals for the wrong day. - Add current_date method returning user’s timezone-aware date - Inject today’s date into prompt before source data, with override instruction to prefer it over stale dates in source data - Prepend current_date to cache key so the image regenerates on date change Fixes usetrmnl#111
Contributor
|
apologies for missing this @natesilva , tagging @ikraamg to review. |
|
Hi @natesilva 👋 Apologies once again for missing this. I have made two changes, one a couple weeks back, and one yesterday that might resolve this bug. Please let me know if this is still a relevant issue for you and I will double down on an improved fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the plugin refreshes after midnight, source plugin data (e.g. calendar’s today_in_tz) may still contain yesterday's date. The Gemini prompt had no independent date reference, causing the LLM to render calendars and date-dependent visuals for the wrong day.
Fixes #111