feat(stovepipe): add BuildStore extension with MySQL implementation#370
Open
roychying wants to merge 3 commits into
Open
feat(stovepipe): add BuildStore extension with MySQL implementation#370roychying wants to merge 3 commits into
roychying wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The stovepipe build pipeline step needs a persistence layer for the Build entity added in #362. Following the immutable-entity + optimistic-locking storage pattern used elsewhere in the codebase (RequestStore, QueueStore), builds need their own store: build creates a row once (at Trigger), and buildsignal is the sole writer of Status/Version afterward. No reverse index from Request to its builds is needed since buildsignal and record always reach a build by the ID carried on their queue messages.
What?
Test Plan
Issue