Avoid crashes when publishing without WebSocket contexts - #1933
Merged
Conversation
Contributor
|
Btw, you come from Node.js right? If so, how did you tackle the NPM change for Git dependencies? You just vendor the binaries? |
Contributor
Author
|
Not originally, but Node.js has pretty much become my new world. I’m still using npm 10 because newer npm versions have introduced too many issues in my workflows. So I haven’t had to deal with the Git dependency change yet - I just install the pinned Git dependency normally and don’t vendor the binaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1924.
Return
falsefrompublishandpublishPrepared, and0fromnumSubscribers, when noWebSocketContexthas been configured.This avoids dereferencing a null
TopicTreewithout allocating one or registering loop handlers for HTTP-only apps.A regression check was added to the existing HTTP-only fuzz target.
Tested by: