Move broken tkl-upgrade-php script out - #369
Open
JedMeister wants to merge 1 commit into
Open
Conversation
OnGle
approved these changes
Jul 29, 2026
OnGle
left a comment
OnGle
left a comment
Member
There was a problem hiding this comment.
Yeah agreed, this is the right move atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing as the current iteration of
tkl-php-upgradeis broken it's better to not include it at all. Besides it's better to package it rather than including it as an overlay script. That way it will be easy for TurnKey users to install & update.For now, it has been moved to it's own repo here: https://github.com/turnkeylinux/tkl-upgrade-php
Once we get some time to circle back to it, it will be fixed and released as a package via our apt repo.
Even though the new tkl-php-upgrade repo does not build a package and is incomplete, now it's been moved to it's own repo the packaging work is now "in progress". So IMO:
Closes turnkeylinux/tracker#2023
OTOH perhaps it should be left open and just tagged "in progress" - which I've just done regardless...
Also related to this show stopper issue (reason why it's being removed):
turnkeylinux/tracker#2074