Bump pybind11 to v2.13.6 to fix builds on modern Python - #582
Open
overlorde wants to merge 1 commit into
Open
Conversation
pybind11 v2.6.2 fails to build against Python 3.11+ because PyFrameObject became an opaque type. v2.13.6 uses the PyFrame_Get* accessor API. Fixes tensor-compiler#560.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building with
-DPYTHON=ONfails on modern Python (3.11+): the pinned pybind11 submodule (v2.6.2) accessesPyFrameObjectfields directly, but that type became opaque in Python 3.11, so pybind11'scast.hfails witherror: invalid use of incomplete type 'PyFrameObject'(#560).Fix
Bump the
python_bindings/pybind11submodule from v2.6.2 to v2.13.6, which uses thePyFrame_Get*accessor API and supports Python 3.11-3.13.Validation
Built TACO with
-DPYTHON=ONagainst Python 3.12.13 and ran a pytaco smoke test: the module imports andc[i] = a[i] + b[i]computes correctly ([1,2,3] + [4,5,6] = [5,7,9]). No changes to TACO's own binding code were needed.Fixes #560.