Skip to content

[6.x] Add missing English translation JSON file#14989

Closed
lazerg wants to merge 1 commit into
statamic:6.xfrom
lazerg:fix/issue-14096-english-translations
Closed

[6.x] Add missing English translation JSON file#14989
lazerg wants to merge 1 commit into
statamic:6.xfrom
lazerg:fix/issue-14096-english-translations

Conversation

@lazerg

@lazerg lazerg commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #14096

Add the missing lang/en.json file with English translations. For the English locale, the translation keys and values are identical.

Includes a test to verify the file is valid JSON and properly symmetric.

@lazerg lazerg changed the title Add missing English translation JSON file [6.x] Add missing English translation JSON file Jul 12, 2026
@lazerg lazerg force-pushed the fix/issue-14096-english-translations branch 2 times, most recently from 459b673 to 66a98d4 Compare July 12, 2026 16:45
@lazerg lazerg force-pushed the fix/issue-14096-english-translations branch from 66a98d4 to af9a118 Compare July 12, 2026 17:18
@jasonvarga

Copy link
Copy Markdown
Member

Thanks for the PR! The actual bug is in JavascriptComposer::translations(), which overrides the frontend's English key-fallback with the fallback locale's translations. Fixing that at the root in a separate PR instead of maintaining lang/en.json by hand - the whole point of json based translations is that you don't need a json file for English. Closing this in favor of that — appreciate the repro, it helped find the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing translations for English result in unexpected localization.

2 participants