Visage v2.4.0 - #747
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been mentioned on Stash Forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in v2.4.0
Visible loading state for face search
The face search trigger lives in the scene Operations dropdown, which closes the moment you click it. The scanning indicator lived on that button, so it was never visible, and the 2-3 second recognition call looked like nothing was happening.
The match modal now opens immediately with a scanning animation, and closes again if the request fails. The sprite modal and performer cards show their own loading state while a lookup is in flight.
Details
START_MATCH_SEARCHaction clears stale matches and opens the modal up frontFaceMatchModalrenders a scanning state instead of an empty result listPerformerCardandSpriteResultModalshow progress during lookupsTests
246 tests pass, including new coverage for the loading states in
FaceMatchModalandPerformerCard. Type check is clean.CSP
connect-srcunchanged:https://cc1234-stashface-onnx.hf.spaceandhttp://localhost:7860only.