Implement market fees configuration and tests - #32
Merged
m-kus merged 9 commits intoAug 22, 2025
Conversation
…in fees Co-authored-by: mz <mz@bakingbad.dev>
This comment was marked as off-topic.
This comment was marked as off-topic.
m-kus
marked this pull request as ready for review
August 22, 2025 08:31
Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
…ture Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
Co-authored-by: mz <mz@bakingbad.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
MarketFeessubstructure to centralize and make fee configuration fully configurable, addressing inconsistencies and potential transaction failures due to ad hoc fee handling.Previously, fee configuration was sparse, hardcoded, or not implemented, leading to potential inconsistencies in transaction calculations (e.g., CTV hash mismatches) and mempool issues. This PR centralizes fee definitions, allowing for configurable deposit, withdraw, and administrator fees, ensuring consistent and correct fee application across all transaction types (deposit, payout).