Skip to content

ROX-34386: Add image labels#162

Open
mtodor wants to merge 3 commits into
release-0.2from
mtodor/ROX-34386-add-labels
Open

ROX-34386: Add image labels#162
mtodor wants to merge 3 commits into
release-0.2from
mtodor/ROX-34386-add-labels

Conversation

@mtodor

@mtodor mtodor commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Since we didn't define labels in Dockerfile build - we get default labels from UBI Micro

Validation

  • Wait for Konflux build
  • Pull image and check labels

@mtodor
mtodor requested a review from janisz as a code owner July 21, 2026 16:04
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The runtime image now includes OCI metadata labels, while both Tekton PipelineRuns define an extra-labels parameter containing a CPE label for the release stream.

Changes

Release metadata

Layer / File(s) Summary
Runtime image labels
konflux.Dockerfile
Adds OCI image descriptors, maintainer and source metadata, release 1, and a version derived from ${VERSION}.
Pipeline label parameters
.tekton/acs-mcp-server-pull-request.yaml, .tekton/acs-mcp-server-push.yaml
Adds the extra-labels parameter with a CPE label value and version-stream update guidance.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: janisz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding image labels.
Description check ✅ Passed The description matches the change by noting Dockerfile labels and image label validation.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mtodor/ROX-34386-add-labels

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@konflux.Dockerfile`:
- Line 73: Redeclare the VERSION build argument in the final Dockerfile stage
immediately before the label that uses it. Ensure the existing version label
receives the supplied VERSION value instead of relying on the out-of-scope ARG
declared before the first FROM.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: dc783983-b071-4a82-977b-45506eb5c8fa

📥 Commits

Reviewing files that changed from the base of the PR and between 0b298ff and bbc7460.

📒 Files selected for processing (1)
  • konflux.Dockerfile

Comment thread konflux.Dockerfile Outdated
@codecov-commenter

codecov-commenter commented Jul 21, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
380 2 378 12
View the full list of 2 ❄️ flaky test(s)
::policy 1

Flake rate in main: 100.00% (Passed 0 times, Failed 66 times)

Stack Traces | 0s run time
- test violation 1
- test violation 2
- test violation 3
::policy 4

Flake rate in main: 100.00% (Passed 0 times, Failed 66 times)

Stack Traces | 0s run time
- testing multiple alert violation messages 1
- testing multiple alert violation messages 2
- testing multiple alert violation messages 3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

E2E Test Results

Commit: 721ced8
Workflow Run: View Details
Artifacts: Download test results & logs

=== Evaluation Summary ===

  ✓ cve-cluster-list (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)
  ✓ cve-cluster-does-exist (assertions: 3/3)
  ✓ cve-cluster-does-not-exist (assertions: 3/3)
  ✓ cve-detected-clusters (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ✓ cve-nonexistent (assertions: 3/3)
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ list-clusters (assertions: 3/3)

Tasks:      11/11 passed (100.00%)
Assertions: 32/32 passed (100.00%)
Tokens:     ~54266 (estimate - excludes system prompt & cache)
MCP schemas: ~12562 (included in token total)
Agent used tokens:
  Input:  13237 tokens
  Output: 20549 tokens
Judge used tokens:
  Input:  65830 tokens
  Output: 54905 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants