Skip to content

refactor!: Make Role::{fixed,estimated}_replica_count standalone#1247

Merged
sbernauer merged 3 commits into
mainfrom
refactor/replica-counting
Jul 9, 2026
Merged

refactor!: Make Role::{fixed,estimated}_replica_count standalone#1247
sbernauer merged 3 commits into
mainfrom
refactor/replica-counting

Conversation

@sbernauer

Copy link
Copy Markdown
Member

Description

Needed in stackabletech/nifi-operator#953

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small idea, otherwise lgtm.

Comment thread crates/stackable-operator/src/role_utils.rs
Comment thread crates/stackable-operator/src/role_utils.rs
Comment thread crates/stackable-operator/src/role_utils.rs
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 9, 2026
@sbernauer
sbernauer enabled auto-merge July 9, 2026 07:25
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 9, 2026
@sbernauer
sbernauer added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit a7f89c2 Jul 9, 2026
5 checks passed
@sbernauer
sbernauer deleted the refactor/replica-counting branch July 9, 2026 07:32
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants