android: show password validation feedback - #10762
Open
ZenulAbidin wants to merge 1 commit into
Open
Conversation
f321x
marked this pull request as ready for review
July 20, 2026 09:27
f321x
marked this pull request as draft
July 20, 2026 09:27
ZenulAbidin
marked this pull request as ready for review
July 21, 2026 13:42
accumulator
requested changes
Aug 5, 2026
| iconStyle: InfoTextArea.IconStyle.Warn | ||
| backgroundColor: constants.darkerDialogBackground | ||
| compact: true | ||
| } |
Member
There was a problem hiding this comment.
Instead of adding an extra InfoTextArea, the message should preferably be combined with the errorMessage Label below, into a single element
ZenulAbidin
force-pushed
the
fix/issue-8497
branch
from
August 5, 2026 10:32
0b35272 to
de1ffdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The Android password dialog already prevented submission of passwords shorter than six characters, but the requirement was only encoded in the disabled OK button. Users were not told why the password could not be accepted.
This makes the existing validation visible without changing the password policy.
Fixes #8497.
Validation
PasswordDialogcomponent, including short, mismatched, valid, and non-confirmation modesgit diff --check