fix(self-hosted): misc. visbility checks#5675
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Account Chat keys ( Workspace settings sidebar now derives org-plane unified sections from Client env flags for Agent block API-key visibility uses new Adds a navigation test asserting the org-plane unified section set from the registry. Reviewed by Cursor Bugbot for commit 2c20b79. Configure here. |
Greptile SummaryThis PR tightens settings visibility for self-hosted and client-side configuration paths. The main changes are:
Confidence Score: 4/5The self-hosted Billing sidebar path needs a fix before merging.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx Important Files Changed
Reviews (1): Last reviewed commit: "add tests" | Re-trigger Greptile |
| * which 404s other viewers — mirror it here so the item never links to | ||
| * a dead page. | ||
| */ | ||
| if (ORGANIZATION_PLANE_UNIFIED_SECTIONS.has(item.id) && !isOrgAdminOrOwner) { |
There was a problem hiding this comment.
On self-hosted instances with billing enabled and a host organization configured, Billing is still shown to non-org-admin workspace users because it is an organization-plane section without selfHostedOverride, so this branch never checks it. The workspace settings page routes Billing through the host-organization admin gate, so clicking the visible sidebar item opens a 404.
Summary
Add tests for section visibility + env var checks. Match server side behavior.
Type of Change
Testing
Tested manually
Checklist