lib/string/: strndupa(3): Remove macro - #1709
Draft
alejandro-colomar wants to merge 1 commit into
Draft
Conversation
We removed all its uses --the last calls were in logoutd(8)--. I've analyzed the remaining code that uses similar functions (strndup(3) and strncat(3)), and it doesn't seem like it would benefit from strndupa(3). The two uses of strndup(3) are in "lib/utmp.c". In one case, it is used to return a new string from a function, so stack memory doesn't work there. In the other case, it's used in a branch, and stored in a pointer; the other branch that can store in that pointer needs strdup(3), so we need malloc(3) memory for compatiblity. We have one use of strncat(3) --also in "lib/utmp.c"--, but that one is truly appending, so strndupa(3) wouldn't work there. Signed-off-by: Alejandro Colomar <alx@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed all its uses --the last calls were in logoutd(8)--. I've analyzed the remaining code that uses similar functions (strndup(3) and strncat(3)), and it doesn't seem like it would benefit from strndupa(3).
The two uses of strndup(3) are in "lib/utmp.c". In one case, it is used to return a new string from a function, so stack memory doesn't work there. In the other case, it's used in a branch, and stored in a pointer; the other branch that can store in that pointer needs strdup(3), so we need malloc(3) memory for compatiblity.
We have one use of strncat(3) --also in "lib/utmp.c"--, but that one is truly appending, so strndupa(3) wouldn't work there.