Skip to content

Update freetype-sys to 0.23 - #78

Merged
mrobinson merged 4 commits into
servo:mainfrom
jschwe:update-min
Jun 11, 2026
Merged

Update freetype-sys to 0.23#78
mrobinson merged 4 commits into
servo:mainfrom
jschwe:update-min

Conversation

@jschwe

@jschwe jschwe commented May 10, 2026

Copy link
Copy Markdown
Member

This is a less invasive alternative to #77 that doesn't touch the bindings.
It does delete all the bindings tests, since those had UB (null-ptr dereference).
freetype-sys 0.23 does require a newer freetype version, and hence might not run on Ubuntu 22.04 out of the box anymore - at least in CI it fails and required updating ot ubuntu 24.04

@jschwe
jschwe requested a review from mrobinson May 10, 2026 16:52
freetype-sys 0.23 doesn't build with the version shipped in ubuntu 22.
Ubuntu 24 doesn't seem to ship libfreetype-dev in CI images by default.

configuration error in freetype-sys in ubuntu 22.04 CI:
```

  thread 'main' (2233) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/freetype-sys-0.23.0/build.rs:21:18:
  called `Result::unwrap()` on an `Err` value:
  pkg-config exited with status code 1
  > PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags freetype2 'freetype2 >= 24.3.18'

  pkg-config output:
    Package dependency requirement 'freetype2 >= 24.3.18' could not be satisfied.
    Package 'freetype2' has version '24.1.18', required version is '>= 24.3.18'

  The system library `freetype2` required by crate `freetype-sys` was not found.
  The file `freetype2.pc` needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
  The PKG_CONFIG_PATH environment variable is not set.

  HINT: if you have installed the library, try setting PKG_CONFIG_PATH to the directory containing `freetype2.pc`.
```
Comment thread Cargo.toml Outdated

@mrobinson mrobinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's bump the version to 0.8 before landing.

@mrobinson
mrobinson added this pull request to the merge queue Jun 11, 2026
Merged via the queue into servo:main with commit cdd3cd6 Jun 11, 2026
3 checks passed
@jschwe
jschwe deleted the update-min branch June 11, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants