WIP: Demonstrate usage of the bitcoin-units compat layer#667
Closed
jamillambert wants to merge 1 commit into
Closed
WIP: Demonstrate usage of the bitcoin-units compat layer#667jamillambert wants to merge 1 commit into
jamillambert wants to merge 1 commit into
Conversation
Depend on the rust-bitcoin compat-layer branch and switch the model layer to stable Amount and Sequence types while preserving the client request helper ergonomics around native bitcoin primitives. Assisted-by: GPT-5.4
jamillambert
force-pushed
the
0716-compat-layer
branch
from
July 17, 2026 19:47
91e1c48 to
cac626f
Compare
jamillambert
changed the title
tcharding
reviewed
Jul 19, 2026
Comment on lines
-740
to
745
| let fee = SignedAmount::from_btc(self.fee).map_err(E::Fee)?; | ||
| let fee = bitcoin::SignedAmount::from_btc(self.fee).map_err(E::Fee)?; | ||
| let change_position = crate::to_u32(self.change_position, "change_position")?; | ||
| Ok(model::WalletCreateFundedPsbt { psbt, fee, change_position }) |
Member
There was a problem hiding this comment.
This can be a stable type, right?
Member
|
Nice! This is pleasant huh. I could bike shed the helper functions and the import alias stuff but as a demo this as awesome, thanks man. Moving forward we need rust-bitcoin/rust-bitcoin#6248 to land then we can get this in. By the time we are ready to merge I'd like to see:
|
Member
|
Please note development has migrated to https://git.rust-bitcoin.org/rust-bitcoin/corepc. Any further comments or pushes here on github may be ignored or lost. Closing since I know @jamillambert is ok with the migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on the rust-bitcoin compat-layer branch and switch the model layer to stable Amount and Sequence types while preserving the client request helper ergonomics around native bitcoin primitives.
Assisted-by: GPT-5.4