fix: reject out-of-range int32 object conversions - #26
Merged
Conversation
operator int32_type() narrowed int64 values without a range check, so `int x = doc["id"]` silently wrapped values outside INT32 bounds. Co-authored-by: Kaius Ruokonen <ruoka@users.noreply.github.com>
ruoka
marked this pull request as ready for review
July 27, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: reject out-of-range int32 object conversions
Bug and impact
object::operator int32_type()narrowedint64values with no range check. Assignments likeint x = doc["id"]/int32_type x = …preferred this conversion overinteger_type(), so values outside[INT32_MIN, INT32_MAX](e.g.3000000000) silently wrapped to a wrongint— data corruption for JSON/FSON integer fields larger than 32 bits.Root cause
The conversion did
return std::get<integer_type>(…);intoint32_type, which is a narrowing conversion with no bounds check.Fix
Reject out-of-range integers with
runtime_errorbefore narrowing; in-rangeint32and explicitinteger_typeextraction unchanged.Validation
Int32ConversionRejectsOutOfRangecovering oversize/undersize throws, in-range min/max, andinteger_typeextraction../tools/CB.sh debug test --tags='\[xson\]'— 424/424 passed.