fix: enforce max_array_size during JSON array decode - #25
Merged
Conversation
The DoS cap was declared but never checked, so arrays could grow without bound. Count elements per nested array and reject past the limit; allow a small custom limit for a fast regression test. Co-authored-by: Kaius Ruokonen <ruoka@users.noreply.github.com>
ruoka
force-pushed
the
cursor/critical-bug-management-265f
branch
from
July 27, 2026 14:56
1275a94 to
48d2f62
Compare
ruoka
marked this pull request as ready for review
July 27, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_array_size(100M elements) was declared as a DoS limit but never checked during JSON array parsing, so arrays could grow without bound.Bug and impact
max_array_sizeelements.Root cause
The constant existed next to the enforced
max_string_length/max_nesting_depthcaps, but array element acceptance paths (array_first/array_next) never counted or rejected oversized arrays.Fix
[/].decoderfor fast regressions.Validation
ArraySizeLimitEnforcedcovering exact limit, overflow, nested arrays, arrays under objects, and empty/short arrays../tools/CB.sh debug test --tags='\[xson\]'— 422/422 passed.