add wiki-gear-setups - #14281
Open
Jiimbones wants to merge 1 commit into
Open
Conversation
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wiki Gear Setups imports the OSRS Wiki's {{Recommended equipment}} tables as Bank Tags layouts, personalised to the gear the player actually owns.
Search a boss or activity from the side panel, pick a combat style, and the plugin reads the wiki's ranked per-slot recommendations, resolves the best item you own for each slot (falling through the alternatives when you don't own the top pick), and writes a ready-to-use tag tab. There's also a "Show wiki BIS" view that ignores ownership, for planning upgrades.
Notes for review:
Writes through the core Bank Tags API only (TagManager, LayoutManager, TabManager); declares @PluginDependency(BankTagsPlugin.class) and refuses to import while Bank Tags is disabled rather than risk corrupting the tab list.
No third-party dependencies - nothing outside what runelite-client already provides.
Network access is read-only requests to the public OSRS Wiki API, off the client thread, with a descriptive User-Agent as the wiki's policy asks. No telemetry, no other endpoints.
Bank contents are read locally and cached per RuneScape profile in the user's own config. Nothing about the player's bank leaves the machine.
257 unit tests, run green from a clean clone of the submitted commit.