WIP Remove Old Layout / Styles#6690
Draft
brian-penguin wants to merge 8 commits into
Draft
Conversation
Why this change is being made: - It's time to cleanup! What were the changes made to support this: -
Why this change is being made: - We aren't loading any of this css into the new application layout anymore so it should be safe to remove. What were the changes made to support this: - Delete delete!
Why this change is being made: - Update the config to point to the hammy_component_preview. I don't see a component_preview one anywhere
Why this change is being made: - Since everything is tailwind we don't need to use the prefix to get the styles! What were the changes made to support this: - remove all the `tw` prefix from the `tw-*` classes
Why this change is being made: - I left a lot of old css classes hanging around in the markup that I don't need! Almost all of this is undefined and unused except where needed for tests. What were the changes made to support this: - Cleanup old classes!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6690 +/- ##
==========================================
- Coverage 97.22% 97.20% -0.03%
==========================================
Files 521 521
Lines 11325 11308 -17
==========================================
- Hits 11011 10992 -19
- Misses 314 316 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.