std::format, concepts, range-for using and string_view#298
Open
ahcorde wants to merge 1 commit into
Open
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
pum1k
reviewed
Jul 20, 2026
Comment on lines
+50
to
+57
| /// Satisfied when interface T can be constructed from Args according to its InterfaceTraits. | ||
| /** | ||
| * Replaces the std::enable_if_t<class_loader::is_interface_constructible_v<...>> SFINAE guard | ||
| * on the create*Instance() methods with a named constraint, yielding clearer diagnostics. | ||
| */ | ||
| template<typename T, typename ... Args> | ||
| concept InterfaceConstructible = class_loader::is_interface_constructible_v<T, Args...>; | ||
|
|
Contributor
There was a problem hiding this comment.
class_loader already provides this concept. I think we should use that, instead of reimplementing it.
Then we can replace all uses of InterfaceConstructible with class_loader::InterfaceConstructible
There was a problem hiding this comment.
@ahcorde this makes sense to me. Could you make the change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 4.7