Skip to content

fix(release): allow promotion to read bound draft - #641

Merged
jeremi merged 1 commit into
mainfrom
codex/fix-release-draft-permission
Aug 1, 2026
Merged

fix(release): allow promotion to read bound draft#641
jeremi merged 1 commit into
mainfrom
codex/fix-release-draft-permission

Conversation

@jeremi

@jeremi jeremi commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary\n\n- allow only the image-promotion job to access the exact nonpublic GitHub Release draft\n- update the existing exact permission-map test\n- leave release steps, artifact bytes, draft binding, and image reconciliation unchanged\n\n## Root cause\n\nPublication run 30713620744 failed on the promotion job's first GET of the bound draft with HTTP 403. The job had contents: read, while GitHub requires push-level contents access to retrieve a draft release. The preceding staging job had contents: write and successfully created and reconciled the same draft.\n\nThe failure happened before registry login. The v0.16.3 draft remains unpublished and exactly bound to candidate manifest f07f537323efde5de690c9388dc3e38b35379358d5350f2ba812fd72c77d6546, and both public v0.16.3 image tags remain absent.\n\n## Security scope\n\nThe additional permission is job-local. The promotion job still re-fetches and validates the exact draft before the first public image write, and it still copies an image only when the final tag is absent or accepts an existing exact digest. Checkout credentials remain disabled, and the job contains no repository, Release, asset, deletion, or publication mutation.\n\n## Verification\n\n- actionlint .github/workflows/release.yml\n- 101 focused release workflow, guard, and gate-inventory tests\n- live gate inventory: 151 gates passed\n- git diff --check\n- independent release diagnosis and security-focused diff review

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66949f05b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml
@jeremi
jeremi merged commit 1efc2a4 into main Aug 1, 2026
28 checks passed
@jeremi
jeremi deleted the codex/fix-release-draft-permission branch August 1, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant