fix(release): allow promotion to read bound draft - #641
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66949f05b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- allow only the image-promotion job to access the exact nonpublic GitHub Release draft\n- update the existing exact permission-map test\n- leave release steps, artifact bytes, draft binding, and image reconciliation unchanged\n\n## Root cause\n\nPublication run 30713620744 failed on the promotion job's first GET of the bound draft with HTTP 403. The job had contents: read, while GitHub requires push-level contents access to retrieve a draft release. The preceding staging job had contents: write and successfully created and reconciled the same draft.\n\nThe failure happened before registry login. The v0.16.3 draft remains unpublished and exactly bound to candidate manifest f07f537323efde5de690c9388dc3e38b35379358d5350f2ba812fd72c77d6546, and both public v0.16.3 image tags remain absent.\n\n## Security scope\n\nThe additional permission is job-local. The promotion job still re-fetches and validates the exact draft before the first public image write, and it still copies an image only when the final tag is absent or accepts an existing exact digest. Checkout credentials remain disabled, and the job contains no repository, Release, asset, deletion, or publication mutation.\n\n## Verification\n\n- actionlint .github/workflows/release.yml\n- 101 focused release workflow, guard, and gate-inventory tests\n- live gate inventory: 151 gates passed\n- git diff --check\n- independent release diagnosis and security-focused diff review