Skip to content

Promote fuseboxScreenshotCaptureEnabled to stable (#57540) #57540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
Closed

Promote fuseboxScreenshotCaptureEnabled to stable (#57540) #57540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<9b295106ef57d7fa85846c57bb74a090>>
* @generated SignedSource<<b9af52e00c2ec40c932a9f3da1719efb>>
*/

/**
Expand Down Expand Up @@ -141,7 +141,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun fuseboxNetworkInspectionEnabled(): Boolean = true

override fun fuseboxScreenshotCaptureEnabled(): Boolean = false
override fun fuseboxScreenshotCaptureEnabled(): Boolean = true

override fun optimizedAnimatedPropUpdates(): Boolean = false

Expand Down
4 changes: 1 addition & 3 deletions ...eact/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<af67163b6d34bb714b783658501ca6e8>>
* @generated SignedSource<<41f83a9921de88f659ddc22172344226>>
*/

/**
Expand All @@ -31,8 +31,6 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android :

override fun fuseboxFrameRecordingEnabled(): Boolean = true

override fun fuseboxScreenshotCaptureEnabled(): Boolean = true

override fun preventShadowTreeCommitExhaustion(): Boolean = true

override fun useSharedAnimatedBackend(): Boolean = true
Expand Down
8 changes: 6 additions & 2 deletions packages/react-native/ReactCommon/jsinspector-modern/tests/HostTargetTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,11 +1632,15 @@ TEST_F(HostTargetTest, TracingDelegateIsNotifiedOnDirectTracingCall) {
page_->stopTracing();
}

TEST_F(HostTargetProtocolTest, CaptureScreenshotNotSupportedWhenFlagDisabled) {
TEST_F(HostTargetProtocolTest, CaptureScreenshotReturnsData) {
EXPECT_CALL(hostTargetDelegate_, captureScreenshot(_))
.WillOnce(Return(std::optional<std::string>("c2NyZWVuc2hvdA==")))
.RetiresOnSaturation();
EXPECT_CALL(
fromPage(),
onMessage(JsonParsed(AllOf(
AtJsonPtr("/error/code", Eq(-32601)), AtJsonPtr("/id", Eq(1))))))
AtJsonPtr("/id", Eq(1)),
AtJsonPtr("/result/data", Eq("c2NyZWVuc2hvdA=="))))))
.RetiresOnSaturation();
toPage_->sendMessage(R"({
"id": 1,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<2c09412cdf8edaf4f7d6d90a446ce6fa>>
* @generated SignedSource<<2c7b47ef5ae156d4e5396cf8b047f187>>
*/

/**
Expand Down Expand Up @@ -264,7 +264,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool fuseboxScreenshotCaptureEnabled() override {
return false;
return true;
}

bool optimizedAnimatedPropUpdates() override {
Expand Down
6 changes: 1 addition & 5 deletions ...t-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSExperimental.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<bcd31ae20312c38ff0bbc8fdeac5ce36>>
* @generated SignedSource<<630f900c13eb68232717fc28528253e2>>
*/

/**
Expand Down Expand Up @@ -43,10 +43,6 @@ class ReactNativeFeatureFlagsOverridesOSSExperimental : public ReactNativeFeatur
return true;
}

bool fuseboxScreenshotCaptureEnabled() override {
return true;
}

bool preventShadowTreeCommitExhaustion() override {
return true;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,15 +680,15 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
fuseboxScreenshotCaptureEnabled: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2026-04-01',
description:
'Enable Page.captureScreenshot CDP method support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.',
expectedReleaseValue: true,
purpose: 'experimentation',
},
ossReleaseStage: 'experimental',
ossReleaseStage: 'stable',
},
optimizedAnimatedPropUpdates: {
defaultValue: false,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<71e307d568421d49e3943f58c4fcb163>>
* @generated SignedSource<<411c2e601987e01db778a82b6237a407>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -450,7 +450,7 @@ export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlag
/**
* Enable Page.captureScreenshot CDP method support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
*/
export const fuseboxScreenshotCaptureEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxScreenshotCaptureEnabled', false);
export const fuseboxScreenshotCaptureEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxScreenshotCaptureEnabled', true);
/**
* When enabled, uses optimized platform-specific paths to apply animated props synchronously. On Android, this uses a batched int/double buffer protocol with a single JNI call. On iOS, this passes AnimatedProps directly through the delegate chain and applies them via cloneProps, avoiding the folly::dynamic round-trip.
*/
Expand Down
Loading