feat: migrate to SceneDelegate#53744
Conversation
…eDelegate and AppDelegate
…ifecycle-originating updates from DeviceEventEmitter
40c091e to
5b4208c
Compare
5b4208c to
5aac7cd
Compare
…ensure devtools will log it too
…ts and animating the container transform, drop RCTResizeThrottler
Introduces an optional RCTSceneDelegate base class alongside the existing RCTAppDelegate path, with RCTGetActiveReactNativeFactory and RCTKeyWindow improvements.
Adopt RCTSceneDelegate in sample apps, wire push notifications on AppDelegate for the scene path, fix native example views to use RCTGetActiveReactNativeFactory, and preserve legacy AppDelegate bootstrap behind compile flags.
e2482e9 to
a0b8944
Compare
abf677c to
d5a5a6d
Compare
cipolleschi
left a comment
There was a problem hiding this comment.
Hi @artus9033, thanks for working on this.
The PR is very detailed and well prepared.
I think we can simplify some assumption to make it smaller and more maintainable.
I left some comments in the PR. Could you address them?
| if (supportsMultipleScenes) { | ||
| RCTLogWarn( | ||
| @"RCTReactNativeFactory: (WARNING - UNSUPPORTED RN APP CONFIGURATION) Your application is running with the Info.plist UIApplicationSceneManifest.UIApplicationSupportsMultipleScenes key set to true, which is NOT supported by React Native at the moment. Allowing the user to run multiple windows of a RN application means allowing to run multiple instances of React Native and libraries in the same process, which may cause ALL SORTS OF PROBLEMS in implementations which use singletons or static storage lifetime variables."); | ||
| } |
There was a problem hiding this comment.
if it is not supported, can't we crash? I think we should raise an exception. A warning in console is very easy to miss. Perhaps we can add a compiler flag that transforms the crash in a warning, but at least users will have to do it themselves and hopefully they'll know what they are doing.
WDYT?
There was a problem hiding this comment.
I agree, we can make this an assertion. I think the option to opt out with a compiler flag is sensible. I do not foresee use cases when users would enable this, because even if they would do so, internal React Native components that use NSNotificationCenter would cross-talk across scenes.
| * - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name | ||
| * jsInvoker:(std::shared_ptr<facebook::react::CallInvoker>)jsInvoker; | ||
| */ | ||
| @interface RCTSceneDelegate : RCTDefaultReactNativeFactoryDelegate <UIWindowSceneDelegate> |
There was a problem hiding this comment.
not a fan of the subclassing. Can't we move away from the subclassing approach and show the users how to use the RCTReactNativeFactory directly? What are they going to miss if they don't use this subclass?
There was a problem hiding this comment.
It's purely a utility to reduce the amount of code the users would need to write. I don't strongly suggest this approach, we can instead document what they need to add and drop this helper.
| #if !defined(RCT_REMOVE_LEGACY_ARCH) | ||
| @property (nonatomic, nullable) RCTBridge *bridge | ||
| __attribute__((deprecated("The bridge is deprecated and will be removed when removing the legacy architecture."))); | ||
| @property (nonatomic, nullable) RCTSurfacePresenterBridgeAdapter *bridgeAdapter __attribute__(( | ||
| deprecated("The bridge adapter is deprecated and will be removed when removing the legacy architecture."))); | ||
| #endif |
There was a problem hiding this comment.
This can be removed. It is not possible to disable New Arch
| - (void)scene:(UIScene *)scene openURLContexts:(NSSet<UIOpenURLContext *> *)URLContexts | ||
| { | ||
| [RCTLinkingManager scene:scene openURLContexts:URLContexts]; | ||
| } | ||
|
|
||
| - (void)scene:(UIScene *)scene continueUserActivity:(NSUserActivity *)userActivity | ||
| { | ||
| [RCTLinkingManager scene:scene continueUserActivity:userActivity]; | ||
| } |
There was a problem hiding this comment.
We probably need to update the website with these. I would not add the RCTSceneDelegate at all.
| if (!RCTIsSceneDelegateApp()) { | ||
| [RCTLinkingManager postNotificationWithURL:URL]; | ||
| return YES; | ||
| } | ||
| return YES; | ||
|
|
||
| return NO; |
There was a problem hiding this comment.
nit: I typically prefer not to have negation logic. I find it easier to read the code.
| if (!RCTIsSceneDelegateApp()) { | |
| [RCTLinkingManager postNotificationWithURL:URL]; | |
| return YES; | |
| } | |
| return YES; | |
| return NO; | |
| if (RCTIsSceneDelegateApp()) { | |
| return NO; | |
| } | |
| [RCTLinkingManager postNotificationWithURL:URL]; | |
| return YES; | |
| #endif | ||
|
|
||
| #import "RCTAppDelegate.h" | ||
| #import "RCTSceneDelegate.h" |
| } | ||
|
|
||
| export default AccessibilityManagerTest; | ||
| module.exports = AccessibilityManagerTest; |
There was a problem hiding this comment.
can we move these js changes to a different PR? They are unrelated from the SceneDelegate.
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #if RNTESTER_USE_APPDELEGATE |
There was a problem hiding this comment.
not sure it is worth to complicate RNTester like this.
Also, I don't want to show a pattern to the user that is not the best one.
I would probably simplify the PR and drop the AppDelegate completely.
| #import <RCTSceneDelegate.h> | ||
| #import <UIKit/UIKit.h> | ||
|
|
||
| @interface SceneDelegate : RCTSceneDelegate |
There was a problem hiding this comment.
what would it be if we do not extend the RCTSceneDelegate?
| @@ -0,0 +1,65 @@ | |||
| /* | |||
There was a problem hiding this comment.
same as above, let's simplify and get rid of this.
27e1c80 to
49816a3
Compare
Summary:
This PR introduces a migration from the now-deprecated iOS AppDelegate to SceneDelegate, as well as the changes to React Native code that will migrate to APIs allowing it to work fine with the SceneDelegate approach. There are two primary goals of this API:
The changes are additive to RN and maintain backwards compatibility, but require user-space modifications to RN apps that want to migrate from AppDelegate to the scene lifecycle.
What changed
Bootstrap (
Libraries/AppDelegate)RCTSceneDelegate- introduced fast integration point for subclassing in the user-space SceneDelegate base class (counterpart toRCTAppDelegate)RCTReactNativeFactory- SceneDelegate entrypoints viaUISceneConnectionOptionsRCTAppDelegateretained; deprecation wording updated to point scene apps toRCTSceneDelegateUtilities (
React/Base)RCTGetActiveReactNativeFactory()- resolve factory from SceneDelegate or AppDelegateRCTKeyWindow()- iOS 13–14 fallback for scene-based appsRCTIsSceneDelegateApp()- dual-path linking detectionLinking (
Libraries/LinkingIOS)RCTLinkingManager; AppDelegate methods retained for non-scene appsCore modules
RCTDeviceInfo- refresh cachedgetConstants()on orientation/frame/content-size changesNativeDeviceInfoJS - remove stale constants cachingRCTDevLoadingView- layout/dismiss fixes for scene window resizingSample apps
RCTSceneDelegate; AppDelegate handles push notificationsRNTESTER_USE_APPDELEGATEAppDelegate.legacy.swiftThe RFC documenting the details is available here.
Example usage:
An example entrypoint using the added
RCTSceneDelegate(imported fromReact_RCTAppDelegate) is:Follow-ups:
After merging this PR, the AppDelegate will be deprecated, but still available. After a future de-integration of AppDelegate,
packages/react-native/Libraries/AppDelegateand contained files should be renamed.Additional information
One capability that can be leveraged with the SceneDelegate on iPadOS is multi-window (multi-instance) support, which would cause all sorts of problems in the current React Native core and 3p libraries' designs. Therefore, enabling this capability is currently unsupported by React Native and to enforce this, a warning message like the one below would be printed provided this capability had been enabled:
Changelog:
[IOS] [ADDED] - SceneDelegate support with backwards compatibility to AppDelegate-only approaches
[IOS] [ADDED] -
RCTSceneDelegate,RCTGetActiveReactNativeFactory(), andRCTReactNativeFactorySceneDelegate entrypoints[IOS] [ADDED] -
RCTLinkingManagerSceneDelegate lifecycle methods (AppDelegate path retained)[IOS] [CHANGED] - DeviceInfo to update the value returned by getConstants upon frame change
[IOS] [CHANGED] - RCTDevLoadingView layout for scene window resizing
[IOS] [ADDED] - additional scheme: RNTester (AppDelegate), allowing to run RNTester with AppDelegate infrastructure
[IOS] [ADDED] - print warning from RCTReactNativeFactory if
UIApplicationSceneManifest.UIApplicationSupportsMultipleScenesin Info.plist is set to true, which is unsupported by RN to prevent bugs due to simultaneously running multiple instances of an appTest Plan:
RNTesterSceneDelegate andRNTester (AppDelegate)schemes)RNTester
ScreenRecording_07-13-2026.12-26-27_1.mov
HelloWorld
ScreenRecording_07-13-2026.13-15-08_1.mov