fix: skip const-fold for arange for attention mask - #4452
Open
fs-eire wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
component: tests
micwill755
reviewed
Aug 4, 2026
| def test_decomposed_attention_mask_aranges_are_not_folded(self): | ||
| self._assert_only_attention_aranges_survive(decompose_attention=True) | ||
|
|
||
| def test_ia_attention_mask_aranges_are_not_folded(self): |
Collaborator
There was a problem hiding this comment.
What is "ia"? Is this a typo?
| from typing import Any, Optional | ||
|
|
||
| import torch | ||
| from torch_tensorrt.dynamo.lowering.constant_fold_exclusions._core import ( |
Collaborator
There was a problem hiding this comment.
Shouldnt we eagerly import attention_mask here, or via the package init, so the rule is always registered when this pass runs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduced a const-fold exclusion rule "attention_mask_arange". With this rule, generated causal mask will be preserved as operations so that later TRT/Myelin can correctly generate optimized layer.
#4450 is required as prerequisite for this PR.
Fixes # (issue)
Type of change
Checklist: