Skip to content

gh-71019: document which objects connect_read_pipe/connect_write_pipe accept and add tests#153660

Merged
kumaraditya303 merged 4 commits into
python:mainfrom
kumaraditya303:gh-71019-connect-pipe-docs
Jul 14, 2026
Merged

gh-71019: document which objects connect_read_pipe/connect_write_pipe accept and add tests#153660
kumaraditya303 merged 4 commits into
python:mainfrom
kumaraditya303:gh-71019-connect-pipe-docs

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 13, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@kumaraditya303
pythongh-71019: Document which objects connect_read_pipe/connect_writ…
0df6a92 
…e_pipe accept

The docs described *pipe* as simply a file-like object, which suggested that
regular files and the standard streams would work. They do not: on Unix only
pipes, sockets and character devices are accepted (anything else raises
ValueError), and on Windows only handles opened for overlapped I/O can be
associated with an I/O completion port, so console handles and file handles
fail asynchronously rather than at call time.

Spell out what is accepted on each platform and note that regular files are
never supported.
@kumaraditya303
add tests
514b46e
@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2026
Closed
@read-the-docs-community

read-the-docs-community Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33562855 | 📁 Comparing 25316c9 against main (1fece44)

  🔍 Preview build  

2 files changed
± library/asyncio-eventloop.html
± library/asyncio-platforms.html

@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 13, 2026
@kumaraditya303 kumaraditya303 marked this pull request as ready for review July 13, 2026 12:54
@kumaraditya303 kumaraditya303 merged commit 7fb315b into python:main Jul 14, 2026
53 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7fb315b0cd53277c6191b4bfd8019f999d49f1f0 3.15

@kumaraditya303 kumaraditya303 deleted the gh-71019-connect-pipe-docs branch July 14, 2026 07:31
@miss-islington-app

miss-islington-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7fb315b0cd53277c6191b4bfd8019f999d49f1f0 3.14

@miss-islington-app

miss-islington-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7fb315b0cd53277c6191b4bfd8019f999d49f1f0 3.13

@bedevere-app

bedevere-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

GH-153685 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 14, 2026
@bedevere-app

bedevere-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

GH-153686 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 14, 2026
@bedevere-app

bedevere-app Bot commented Jul 14, 2026

Copy link
Copy Markdown

GH-153687 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2026
kumaraditya303 added a commit that referenced this pull request Jul 14, 2026
@kumaraditya303
[3.13] gh-71019: document which objects connect_read_pipe/connect_wri…
32ba4e1 
…te_pipe accept and add tests (GH-153660) (#153687)

gh-71019: document which objects connect_read_pipe/connect_write_pipe accept and add tests (GH-153660)

(cherry picked from commit 7fb315b)
kumaraditya303 added a commit that referenced this pull request Jul 14, 2026
@kumaraditya303
[3.15] gh-71019: document which objects connect_read_pipe/connect_wri…
9465c84 
…te_pipe accept and add tests (GH-153660) (#153685)

gh-71019: document which objects connect_read_pipe/connect_write_pipe accept and add tests (GH-153660)

(cherry picked from commit 7fb315b)
kumaraditya303 added a commit that referenced this pull request Jul 14, 2026
@kumaraditya303
[3.14] gh-71019: document which objects connect_read_pipe/connect_wri…
e2818a7 
…te_pipe accept and add tests (GH-153660) (#153686)

gh-71019: document which objects connect_read_pipe/connect_write_pipe accept and add tests (GH-153660)

(cherry picked from commit 7fb315b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kumaraditya303