Retain leading zeros for Pod uid label - #802
Conversation
|
Just an FYI, I also have #800 open - so if either is accepted, the other will need to be rebased and fixed, but I didn't want to be presumptuous and based off the other branch. |
frouioui
left a comment
frouioui
left a comment
There was a problem hiding this comment.
Looks good to me, and good catch. Just one comment
| package vitessshard | ||
|
|
There was a problem hiding this comment.
You will need a header comment here, similar to what pkg/controller/vitessshard/reconcile_tablets.go has.
There was a problem hiding this comment.
Codex caught that we'll need to update test/endtoend/utils.sh as well:
vitess-operator/test/endtoend/utils.sh
Line 176 in c0d5afe
| } | ||
| labels[planetscalev2.CellLabel] = tabletAlias.Cell | ||
| labels[planetscalev2.TabletUidLabel] = strconv.FormatUint(uint64(tabletAlias.Uid), 10) | ||
| labels[planetscalev2.TabletUidLabel] = fmt.Sprintf("%010d", tabletAlias.Uid) |
There was a problem hiding this comment.
Nit: it might be nice to extract this to a helper (maybe pkg/operator/vttablet/uid.go#UIDString` or similar) that other parts of the code can use. For example, here's another use-case:
f50e3b2 to
29e090b
Compare
|
|
@absolutejam GitHub actions seems to be stuck in some odd state. Typically the only way to move forward is to push an empty to commit. The CI is the only thing blocking the merge at this point. Thanks! |
Signed-off-by: James Booth <james@absolutejam.co.uk>
6e90c05 to
fb57d9a
Compare
|
Is it still the same? If so, I can push an empty commit (With sign-off, for DCO) - but will that get merged into the |
|
@absolutejam I'm sorry, but we might need to merge in origin/main in order to get this: #805 Let's see... |
|
@absolutejam yeah, looks like that will be required. Sorry for the hassle. |
|
@absolutejam I'm going to merge in origin/main. I have way too many things in my review queue and I think that is all that is holding this one up. |
|
Thanks for that - Apologies for the silence but I have been on leave |
4 participants
#801