Skip to content

Fix last trough assignment #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sejalpunwatkar wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix last trough assignment #99

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8ee4a5
Fix: Correct assignment bug in check_troughs
sejalpunwatkar Mar 19, 2026
b011dcb
Fix: Correct assignment bug in check_troughs
sejalpunwatkar Mar 19, 2026
eaac69c
Add edge case handling to check_troughs
sejalpunwatkar Jun 20, 2026
c9cdb55
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion peakdet/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,15 @@ def check_troughs(data, peaks, troughs=None):
troughs : np.ndarray
Indices of trough locations in `data`, dependent on `peaks`
"""
if peaks is None or len(peaks) == 0:
return np.array([])
if len(peaks) == 1:
return np.array([])

# If there's a trough after all peaks, keep it.
if troughs is not None and troughs[-1] > peaks[-1]:
all_troughs = np.zeros(peaks.size, dtype=int)
assert all_troughs[-1] == troughs[-1]
all_troughs[-1] = troughs[-1]
else:
all_troughs = np.zeros(peaks.size - 1, dtype=int)

Expand Down